Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Alerts changes for expected value addition #1138

Merged
merged 10 commits into from
Sep 27, 2022
Merged

Alerts changes for expected value addition #1138

merged 10 commits into from
Sep 27, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Sep 26, 2022

Part of #1132

Tasks

  • Update alerts percent change calculation
  • Update alerts dashboard
  • Update email individual alert
  • Update email alert report
  • Update slack individual alert
  • Update slack alert report
  • Alerts DB migration

@Samyak2 Samyak2 added 🛠️ backend ❗alerts Alert formatting, scheduling, etc. ⚠️ has db migration The changes contain a new database migration. Use caution before merging. 📎 needs docs update A PR that requires updating the docs (https://github.com/chaos-genius/chaosgenius-docs) labels Sep 26, 2022
@Samyak2 Samyak2 added this to the v0.11.0 milestone Sep 26, 2022
@Samyak2 Samyak2 requested a review from Amatullah September 26, 2022 06:17
@gitpod-io
Copy link

gitpod-io bot commented Sep 26, 2022

@Amatullah Amatullah mentioned this pull request Sep 26, 2022
Merged
6 tasks
Amatullah
Amatullah approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@Amatullah Amatullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested locally Email and Slack, Individual alerts and Daily reports for both daily and hourly KPIs

@Samyak2 Samyak2 merged commit 65f975f into expected-value Sep 27, 2022
@Samyak2 Samyak2 deleted the expected-value-alerts branch September 27, 2022 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amatullah Amatullah Amatullah approved these changes

Assignees
No one assigned
Labels
❗alerts Alert formatting, scheduling, etc. 🛠️ backend 📎 needs docs update A PR that requires updating the docs (https://github.com/chaos-genius/chaosgenius-docs) ⚠️ has db migration The changes contain a new database migration. Use caution before merging.
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Samyak2 @Amatullah