Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Add Expected Value to Anomaly and Alerts #1132

Merged
merged 27 commits into from
Sep 27, 2022
Merged

Add Expected Value to Anomaly and Alerts #1132

merged 27 commits into from
Sep 27, 2022

Conversation

Amatullah
Copy link
Member

@Amatullah Amatullah commented Sep 22, 2022 •
edited
Loading

Changes Proposed:

Add Expected Value to Anomaly Detection and Alerts.

Technical Design Document: Expected Value PRD+TDD

Alerts Changes: #1138

Changes:

  • Update all anomaly models
  • Update Processor() class
  • Anomaly DB Migration
  • Update Anomaly API endpoint
  • Update anomaly tests

Tests:

  • Run anomaly detection using all models for daily and hourly KPIs

@Amatullah Amatullah added ✨ enhancement New feature or request 🛠️ backend ❗alerts Alert formatting, scheduling, etc. labels Sep 22, 2022
@Amatullah Amatullah added this to the v0.11.0 milestone Sep 22, 2022
@Amatullah Amatullah requested a review from Samyak2 September 22, 2022 08:21
@Amatullah Amatullah self-assigned this Sep 22, 2022
@netlify
Copy link

netlify bot commented Sep 22, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 4e86c56
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/6332c68558ddd60008fc9b2b

@gitpod-io
Copy link

gitpod-io bot commented Sep 22, 2022

@Amatullah Amatullah marked this pull request as draft September 22, 2022 08:22
Samyak2 and others added 16 commits September 22, 2022 16:47
@Samyak2
fix(core): use notna() to check for Nones
fb7f45f
@ChartistDev
added expected value in tooltip for anomaly graphs
f22ffc5
@ChartistDev
added n/a for unacceptable values
247c60f
@Samyak2
fix(core): replace missing yhats with None/null
4d4fb2f 
In some cases `df[col`] can be `np.nan`, so explicitly replace those
values with None.

The type checker does not like this for some reason.
@ChartistDev
correted incorrect expected value
c80e34e
@ChartistDev
removed unwanted console log
202a002
@Samyak2
feat(alerts): add yhat to point models and update change percent calc
1a0ac20
@Amatullah
fix: use pd.concat instead of pd.append
e25fa1d
@Amatullah
fix(tests): update anomaly tests
8ace7ef
@Samyak2
feat(migration): remove old percent_change from triggered alerts
250d919
@Samyak2
fix(alerts): update data structure and dashboard
a5aac9e
@Samyak2
fix(alerts): change CSV headers according to new structure
a3fd4e5
@Samyak2
fix(alert-dashboard): move change last and name it "Alert Description"
80773e4
@Samyak2
feat(email-alerts): update to use new percent change (from expected)
0bf49ef
@Samyak2
feat(slack-alerts): update to use new percent change (from expected)
6cf67d5
@Samyak2
fix(alerts): move previous value col before actual value
5b7f6fa
@Samyak2 Samyak2 mentioned this pull request Sep 26, 2022
Merged
7 tasks
Samyak2
Samyak2 reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor comments ⬇️

@Samyak2 Samyak2 marked this pull request as ready for review September 27, 2022 09:46
Samyak2
Samyak2 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samyak2 Samyak2 merged commit d01d711 into develop Sep 27, 2022
@Samyak2 Samyak2 deleted the expected-value branch September 27, 2022 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Samyak2 Samyak2 Samyak2 approved these changes

Assignees

@Amatullah Amatullah

Labels
❗alerts Alert formatting, scheduling, etc. 🛠️ backend ✨ enhancement New feature or request
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Amatullah @Samyak2 @ChartistDev