chore: typed cascade reducer #426

atarashansky · 2022-08-25T21:32:50Z

No description provided.

codecov · 2022-08-25T21:38:46Z

Codecov Report

Merging #426 (ef47098) into main (c7033d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files          90       90           
  Lines        6778     6778           
=======================================
  Hits         5142     5142           
  Misses       1636     1636

Flag	Coverage Δ
frontend	`75.86% <ø> (ø)`
javascript	`75.86% <ø> (ø)`
smokeTest	`?`
unitTest	`75.86% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

client/src/reducers/cascade.ts

client/src/reducers/centroidLabels.ts

client/src/reducers/continuousSelection.ts

client/src/reducers/datasetMetadata.ts

client/src/reducers/layoutChoice.ts

client/src/reducers/quickGenes.ts

tihuan

Thanks for the PR, Alec 🤩 ! Let's keep the action types, since the reducers use them 👌

Thanks again! ⭐

client/src/reducers/cascade.ts

Co-authored-by: Severiano Badajoz <[email protected]>

tihuan

Thanks so much for taking care of this PR quickly!! 🔥 ✨ Have an amazing weekend!

* chore: updating logo (#389) * chore: updating logo * feature: Added loading spinner to geneset average color-by and fixed a continuous legend bug (#384) * added loading spinner to mean colorby and fixed legend async bug * revert prettier * temp fix tsc emit * typed * fix * fixed bugs Co-authored-by: atarashansky <[email protected]> * typed obs crossfilter (#420) Co-authored-by: atarashansky <[email protected]> * typed categorical selection reducer (#417) Co-authored-by: atarashansky <[email protected]> * typed differential reducer (#419) Co-authored-by: atarashansky <[email protected]> * typed annoMatrix reducer (#416) Co-authored-by: atarashansky <[email protected]> * chore: purge autosave from codebase (#425) * chore: typed genesetsUI reducer * fix tsc error * chore: purge autosave * delete nameNewAnnotation * remove unused Co-authored-by: atarashansky <[email protected]> * chore: typed controls reducer (#418) * typed controls reducer * refine scatterplot accessor type to be string or false * address revisions * type level return function Co-authored-by: atarashansky <[email protected]> * typed point dilation (#421) Co-authored-by: atarashansky <[email protected]> * Revert "feat: add cellxgene schema 3.0.0 fields to Standard Categories (#412)" (#428) This reverts commit b265fcf. * typed graph selection reducer (#422) Co-authored-by: atarashansky <[email protected]> * chore: typed cascade reducer (#426) * test * update cascade reducer * add map as possible type for cascade * refactor(cascadeReducer): Quick feedback (#427) * revert changes * Update client/src/reducers/cascade.ts Co-authored-by: Severiano Badajoz <[email protected]> * remove as string * refactor(cascadeReducer): Quick feedback 2 (#430) Co-authored-by: atarashansky <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]> * chore: typed genesetsUI reducer (#423) * chore: typed genesetsUI reducer * fix tsc error Co-authored-by: atarashansky <[email protected]> * chore: typed config reducer (#424) * chore: typed config reducer * restrict error type Co-authored-by: atarashansky <[email protected]> Co-authored-by: ashin-czi <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: Nayib Gloria <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]>

* chore: updating logo (#389) * chore: updating logo * feature: Added loading spinner to geneset average color-by and fixed a continuous legend bug (#384) * added loading spinner to mean colorby and fixed legend async bug * revert prettier * temp fix tsc emit * typed * fix * fixed bugs Co-authored-by: atarashansky <[email protected]> * typed obs crossfilter (#420) Co-authored-by: atarashansky <[email protected]> * typed categorical selection reducer (#417) Co-authored-by: atarashansky <[email protected]> * typed differential reducer (#419) Co-authored-by: atarashansky <[email protected]> * typed annoMatrix reducer (#416) Co-authored-by: atarashansky <[email protected]> * chore: purge autosave from codebase (#425) * chore: typed genesetsUI reducer * fix tsc error * chore: purge autosave * delete nameNewAnnotation * remove unused Co-authored-by: atarashansky <[email protected]> * chore: typed controls reducer (#418) * typed controls reducer * refine scatterplot accessor type to be string or false * address revisions * type level return function Co-authored-by: atarashansky <[email protected]> * typed point dilation (#421) Co-authored-by: atarashansky <[email protected]> * Revert "feat: add cellxgene schema 3.0.0 fields to Standard Categories (#412)" (#428) This reverts commit b265fcf. * typed graph selection reducer (#422) Co-authored-by: atarashansky <[email protected]> * chore: typed cascade reducer (#426) * test * update cascade reducer * add map as possible type for cascade * refactor(cascadeReducer): Quick feedback (#427) * revert changes * Update client/src/reducers/cascade.ts Co-authored-by: Severiano Badajoz <[email protected]> * remove as string * refactor(cascadeReducer): Quick feedback 2 (#430) Co-authored-by: atarashansky <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]> * chore: typed genesetsUI reducer (#423) * chore: typed genesetsUI reducer * fix tsc error Co-authored-by: atarashansky <[email protected]> * chore: typed config reducer (#424) * chore: typed config reducer * restrict error type Co-authored-by: atarashansky <[email protected]> Co-authored-by: ashin-czi <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: Nayib Gloria <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]> Co-authored-by: ashin-czi <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: atarashansky <[email protected]> Co-authored-by: Nayib Gloria <[email protected]> Co-authored-by: Timmy Huang <[email protected]> Co-authored-by: Severiano Badajoz <[email protected]>

test

833a713

update cascade reducer

bf10bbd

atarashansky marked this pull request as ready for review August 25, 2022 21:51

add map as possible type for cascade

d721cd0

atarashansky commented Aug 25, 2022

View reviewed changes

client/src/reducers/cascade.ts Outdated Show resolved Hide resolved