chore: typed cascade reducer

client/src/reducers/cascade.ts

@@ -1,5 +1,18 @@
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-explicit-any -- - FIXME: disabled temporarily on migrate to TS.
-export default function cascadeReducers(arg: any) {
+import { AnyAction } from "redux";
+import type { RootState } from ".";
+
+export type ReducerFunction = (
+  prevStateForKey: any,
+  action: AnyAction,
+  nexState?: RootState,
+  prevState?: RootState
+) => any;
+
+type CascadedReducers =
+  | [string, ReducerFunction][]
+  | Map<string, ReducerFunction>;
+
+export default function cascadeReducers(arg: CascadedReducers) {
   /*
   Combine a set of cascading reducers into a single reducer.  Cascading
   reducers are reducers which may rely on state computed by another reducer.
@@ -24,23 +37,24 @@ export default function cascadeReducers(arg: any) {
   */
   const reducers = arg instanceof Map ? arg : new Map(arg);
   const reducerKeys = [...reducers.keys()];
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
-  return (prevState: any, action: any) => {
-    const nextState = {};
+
+  return (prevState: RootState, action: AnyAction) => {
+    const nextState: RootState = {};
     let stateChange = false;
     for (let i = 0, l = reducerKeys.length; i < l; i += 1) {
-      const key = reducerKeys[i];
+      const key = reducerKeys[i] as string;
       const reducer = reducers.get(key);
-      const prevStateForKey = prevState ? prevState[key] : undefined;
-      const nextStateForKey = reducer(
-        prevStateForKey,
-        action,
-        nextState,
-        prevState
-      );
-      // @ts-expect-error ts-migrate(7053) FIXME: Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
-      nextState[key] = nextStateForKey;
-      stateChange = stateChange || nextStateForKey !== prevStateForKey;
+      if (reducer) {
+        const prevStateForKey = prevState ? prevState[key] : undefined;
+        const nextStateForKey = reducer(
+          prevStateForKey,
+          action,
+          nextState,
+          prevState
+        );
+        nextState[key] = nextStateForKey;
+        stateChange = stateChange || nextStateForKey !== prevStateForKey;
+      }
     }
     return stateChange ? nextState : prevState;
   };

client/src/reducers/centroidLabels.ts

@@ -1,20 +1,16 @@
-import type { Action } from "redux";
+import type { AnyAction } from "redux";
 
 export interface CentroidLabelsState {
   showLabels: boolean;
 }
 
-export interface CentroidLabelsAction extends Action<string> {
-  showLabels: boolean;
-}
-
 const initialState: CentroidLabelsState = {
   showLabels: false,
 };
 
 const centroidLabels = (
   state = initialState,
-  action: CentroidLabelsAction,
+  action: AnyAction,
   // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
   sharedNextState: any
 ): CentroidLabelsState => {

client/src/reducers/continuousSelection.ts

@@ -1,22 +1,13 @@
-import type { Action } from "redux";
-
+import type { AnyAction } from "redux";
 import { makeContinuousDimensionName } from "../util/nameCreators";
 
-import type { ContinuousNamespace } from "../util/nameCreators";
-
-export interface ContinuousSelectionAction extends Action<string> {
-  continuousNamespace: ContinuousNamespace;
-  selection: string;
-  range: [number, number];
-}
-
 export interface ContinuousSelectionState {
   [name: string]: [number, number];
 }
 
 const ContinuousSelection = (
   state: ContinuousSelectionState = {},
-  action: ContinuousSelectionAction
+  action: AnyAction
 ): ContinuousSelectionState => {
   switch (action.type) {
     case "reset subset":

client/src/reducers/datasetMetadata.ts

@@ -3,20 +3,11 @@
  */
 
 // Core dependencies
-import { Action } from "redux";
+import { AnyAction } from "redux";
 
 // App dependencies
 import { DatasetMetadata as IDatasetMetadata } from "../common/types/entities";
 
-/*
- Action dispatched on successful response from dataset-metadata endpoint.
- */
-export interface DatasetMetdataAction extends Action<string> {
-  datasetMetadata: IDatasetMetadata;
-  error: string;
-  portalUrl: string;
-}
-
 /*
  Dataset metdata state; selected dataset ID and corresponding collection information.
  */
@@ -36,7 +27,7 @@ const DatasetMetadata = (
     datasetMetadata: null,
     portalUrl: null,
   },
-  action: DatasetMetdataAction
+  action: AnyAction
 ): DatasetMetadataState => {
   switch (action.type) {
     case "initial data load start":

client/src/reducers/layoutChoice.ts

@@ -8,8 +8,9 @@ about commonly used names.  Preferentially, pick in the following order:
   4. give up, use the first available
 */
 
-import type { Action } from "redux";
+import type { AnyAction } from "redux";
 import { EmbeddingSchema, Schema } from "../common/types/schema";
+import type { RootState } from ".";
 
 function bestDefaultLayout(layouts: Array<string>): string {
   const preferredNames = ["umap", "tsne", "pca"];
@@ -33,15 +34,10 @@ export interface LayoutChoiceState {
   currentDimNames: Array<string>;
 }
 
-export interface LayoutChoiceAction extends Action<string> {
-  layoutChoice: string;
-}
-
 const LayoutChoice = (
   state: LayoutChoiceState,
-  action: LayoutChoiceAction,
-  // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types,  @typescript-eslint/no-explicit-any --- FIXME: disabled temporarily on migrate to TS.
-  nextSharedState: any
+  action: AnyAction,
+  nextSharedState: RootState
 ): LayoutChoiceState => {
   switch (action.type) {
     case "initial data load complete": {

client/src/reducers/quickGenes.ts

@@ -1,21 +1,16 @@
 import uniq from "lodash.uniq";
 import filter from "lodash.filter";
+import { AnyAction } from "redux";
 import type { RootState } from ".";
 import { track } from "../analytics";
 import { EVENTS } from "../analytics/events";
 
-interface QuickGenesActions {
-  type: string;
-  gene: string;
-  selection: string;
-  data: string;
-}
 const quickGenes = (
   state: { userDefinedGenes: string[]; userDefinedGenesLoading: boolean } = {
     userDefinedGenes: [],
     userDefinedGenesLoading: false,
   },
-  action: QuickGenesActions,
+  action: AnyAction,
   nextSharedState: RootState
 ) => {
   switch (action.type) {