ignore whitespace. press enter with no input or input ended by whitespace #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdine
reviewed
Jul 9, 2020
.gitignore
Outdated
| @@ -22,3 +22,6 @@ profile.* | |||
|
|
|||
| # Databases | |||
| *.db | |||
| *.idea | |||
There was a problem hiding this comment.
This should not be added to this PR by rather to your global .gitignore. Read this to see how to do it https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/
cmd/genji/shell/shell.go
Outdated
| //If we press enter without any query | ||
| case len(in) == 0: | ||
| return sh.QueryError(in) | ||
| // If it ends by espace "; " |
There was a problem hiding this comment.
This check is not necessary if we trim in
cmd/genji/shell/shell.go
Outdated
| @@ -184,6 +184,16 @@ func (sh *Shell) execute(in string) { | |||
| } | |||
| } | |||
|
|
|||
| // Query Error return an error if we press return with no input, or ended by whitespace | |||
| func (sh *Shell) QueryError(in string) error { | |||
There was a problem hiding this comment.
The name of this function doesn't seem to have anything to do with the content of the function, does it?
tzzed
changed the title
tzzed
added a commit
to tzzed/genji
that referenced
this pull request
Jul 10, 2020
|
implementation of @asdine's suggestion for a simpler version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this a fix of #106
and
both are fixed.