Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore input with whitespace only #106

Closed
asdine opened this issue Jun 28, 2020 · 1 comment · Fixed by #126
Closed

Ignore input with whitespace only #106

asdine opened this issue Jun 28, 2020 · 1 comment · Fixed by #126
Labels
cli Command line good first issue Good for newcomers
Milestone

Comments

@asdine
Copy link
Collaborator

asdine commented Jun 28, 2020

Whenever we press return with no input or whitespace only input in the CLI, it invites the user to add a ;.
We should simply ignore the input.

Current behavior:

genji> <press return, with or without whitespace>
... <press ';', then return>
genji>

Expected behavior:

genji> <press return, with or without whitespace>
genji>
@asdine asdine added good first issue Good for newcomers cli Command line labels Jun 28, 2020
@asdine asdine added this to the v0.7.0 milestone Jun 28, 2020
@yaziine
Copy link
Collaborator

yaziine commented Jul 1, 2020

If we run a query with whitespace after the ;, it also invites to add a ;.

genji> create table foo; <press return with whitespace after the ; >
... <press ';', then return>
genji>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command line good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants