Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ww datap 1179 text link update #464

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Ww datap 1179 text link update #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a12de63
Edits the text displayed when the user clicks the "All" button in the…
Sep 11, 2023
5bda4f7
Edits Learn More link to point to 'Past product and issue changes' se…
Sep 12, 2023
0ad4551
Updated snapshot for DateFilter.spec.js
Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/ccdb5.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/ccdb5.css.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/ccdb5.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/ccdb5.js.LICENSE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ object-assign
*/

/**
* @remix-run/router v1.0.2
* @remix-run/router v1.8.0
*
* Copyright (c) Remix Software Inc.
*
Expand All @@ -114,7 +114,7 @@ object-assign
*/

/**
* React Router DOM v6.4.2
* React Router DOM v6.15.0
*
* Copyright (c) Remix Software Inc.
*
Expand All @@ -125,7 +125,7 @@ object-assign
*/

/**
* React Router v6.4.2
* React Router v6.15.0
*
* Copyright (c) Remix Software Inc.
*
Expand Down
2 changes: 1 addition & 1 deletion dist/ccdb5.js.map
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions src/components/Filters/DateFilter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,10 @@ dayjs.extend(dayjsIsBetween);
dayjs.extend(dayjsUtc);

const WARN_SERIES_BREAK =
'CFPB updated product and issue options' +
' available to consumers in April 2017 ';
'CFPB updated product and issue options in April 2017 and August 2023';

const LEARN_SERIES_BREAK =
'https://files.consumerfinance.gov/f/' +
'documents/201704_cfpb_Summary_of_Product_and_Sub-product_Changes.pdf';
'https://www.consumerfinance.gov/data-research/consumer-complaints/#past-changes';

export const DateFilter = () => {
const fieldName = 'date_received';
Expand Down Expand Up @@ -224,6 +222,7 @@ export const DateFilter = () => {
aria-label="Learn more about Product and
Issue changes (opens in new window)"
>
{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this space necessary?

Learn More
</a>
</p>
Expand Down
5 changes: 3 additions & 2 deletions src/components/Filters/__tests__/__snapshots__/DateFilter.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,14 @@ exports[`component::DateFilter snapshot shows a warning for April 2017 1`] = `
</section>
<p>

CFPB updated product and issue options available to consumers in April 2017
CFPB updated product and issue options in April 2017 and August 2023
<a
aria-label="Learn more about Product and Issue changes (opens in new window)"
href="https://files.consumerfinance.gov/f/documents/201704_cfpb_Summary_of_Product_and_Sub-product_Changes.pdf"
href="https://www.consumerfinance.gov/data-research/consumer-complaints/#past-changes"
rel="noopener noreferrer"
target="_blank"
>

Learn More
</a>
</p>
Expand Down
Loading