Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ww datap 1179 text link update #464

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

wwhorton
Copy link
Contributor

This PR updates the text that appears when a user selects "All" in the date range filter and points the "Learn More" link to "https://www.consumerfinance.gov/data-research/consumer-complaints/#past-changes" per the request in DATAP-1179.

Changes

  • Text and link in DateFilter.js
  • updated snapshot for DateFilter.spec.js

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@wwhorton wwhorton marked this pull request as ready for review September 12, 2023 15:29
@@ -224,6 +222,7 @@ export const DateFilter = () => {
aria-label="Learn more about Product and
Issue changes (opens in new window)"
>
{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this space necessary?

Copy link
Member

@anselmbradford anselmbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a question about the space.

Also, is it expected that the dist CSS file is updated?

@contolini contolini added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit a738038 Sep 29, 2023
1 check passed
@anselmbradford anselmbradford deleted the WW-DATAP-1179-text-link-update branch September 29, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants