Implement suggestions preview pane like in core google plugin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoamaro
reviewed
Feb 27, 2017
| * @return {Promise} | ||
| */ | ||
| const getSuggestions = (query) => { | ||
| const url = `https://duckduckgo.com/ac/?q=${query}` |
There was a problem hiding this comment.
@KELiON omg! I was still reading DuckDuckGo's docs and you already made this as a working feature. Incredible! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo I'm going to create additional package (like
cerebro-tools) with common UI elements, likeKeyboardNav,Loading, etc. Now it is just copy from main repository, but as soon as I publish this package these components could be reused.Screenshot:
