Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select emoji with a keyboard #2

Open
maximbaz opened this issue Mar 21, 2017 · 4 comments
Open

Select emoji with a keyboard #2

maximbaz opened this issue Mar 21, 2017 · 4 comments

Comments

@maximbaz
Copy link

maximbaz commented Mar 21, 2017

How hard would it be to allow selecting emoji with arrow keys (or Ctrl+jklh in the latest Cerebro), and copying it with Enter (or Ctrl+o)? That would be very cool for accessibility, no need to reach for a mouse just to copy one of the emojis.

Update: oh, I see @tiagoamaro already suggested that in #1 🙂

@tiagoamaro
Copy link
Contributor

@maximbaz that's a very good suggestion, but not so "quick" to code. I imagine @KELiON is busy right now as I'm also busy to code it. There are some plugins that implement it as my cerebro/duck-duck-go plugin.

As you can see, @KELiON contributed himself to add keyboard navigation to that: cerebroapp/cerebro-duck-duck-go#1. The approach wouldn't be hard :)

PR's are always welcome 🎉!

@KELiON
Copy link
Collaborator

KELiON commented Mar 21, 2017

I'd also like to see this keyboard nav!

@tiagoamaro in case of this plugin it will be a bit harder, because in google/duck-duck-go plugin items are located vertically and could be navigated only with up/down keys:

screen shot 2017-03-21 at 17 37 41

But in this plugin we have a grid with dynamic count of items horizontally/vertically:

screen shot 2017-03-21 at 17 38 30
screen shot 2017-03-21 at 17 38 06

I think changing it to some fixed grid layout will solve the problem so we can navigate with arrows or cmd/ctrl+hjkl

@tiagoamaro
Copy link
Contributor

tiagoamaro commented Mar 21, 2017 via email

@maximbaz
Copy link
Author

Whatever the implementation we end up with, let's make sure we will be allowed to perform the following navigation:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants