Regression for VMBDALI starting at 2024.7.0

[dverhelst]

Hi,

Since version I am 2024.7.0 no longer able to use my 'old' VMBDALI module anymore. In another location an updated VMBDALI-20 seems to load, but is not showing any channels with version >2024.7.0.

INFO:velbus-handler:No cache yet, so forcing a bus scan
INFO:velbus-handler:Start module scan
INFO:velbus-handler:Starting handling scan 1
INFO:velbus-handler:Starting scan 1
INFO:velbus:Found module 1: <{} type:69 address:1 loaded:False loading:False channels: {}>
DEBUG:velbus-handler:Module 1 detected: start loading
INFO:velbus-handler:Scan module 1 completed, module loaded=True
INFO:velbus-handler:Starting handling scan 2
INFO:velbus-handler:Starting scan 2

Same scan on same version ( and same requirements.txt ) on another location with a VMBDALI-20 seems to work up to module level, but is not loading any channels.

INFO:velbus-handler:No cache yet, so forcing a bus scan
INFO:velbus-handler:Start module scan
INFO:velbus-handler:Starting handling scan 1
INFO:velbus-handler:Starting scan 1
INFO:velbus:Found module 1: <{} type:90 address:1 loaded:False loading:False channels: {}>
DEBUG:velbus-handler:Module 1 detected: start loading
INFO:velbus-handler:Scan module 1 completed, module loaded=True
INFO:velbus-handler:Starting handling scan 2
INFO:velbus-handler:Starting scan 2
...
...
<None type:90 address:1 loaded:True loading:False channels: {}>

<None type:90 address:1 loaded:True loading:False channels: {}>

<None type:90 address:1 loaded:True loading:False channels: {}>

<None type:90 address:1 loaded:True loading:False channels: {}>

Is module type '69' no longer detected as a VMBDALI and where's the channels?

Please advise, let me know what else I can do to help and thanks in advance!

[niobos]

This regression was introduces in ac557be, when the change I made in 2583515 was partially reverted. It re-introduces the double-underscore, which makes that method not overridable.

If this is the only thing, it should be easy to fix, but maybe there is more.

[niobos]

@sidlgor, @cereal2nd I see two changes in ac557be that I'm trying to understand. I've read the commit message, but that didn't resolve my questions. Can you elaborate on the reasoning behind these changes? I don't want to break the new things you introduced by just rolling these back.

• you renamed the Module._load_default_channels() method to __load_default_channels()

• you added await super().load() to the beginning of the VmbDali implementation of _load_default_channels()

[cereal2nd]

can you make a pull-request out of these commits?
this looks ok to me.

[sidlgor]

Sorry, my mistake, overlooked overload for VMBDali (bad excuse: I don't own VmbDali)
@niobos Thx for fix 👍

[dverhelst]

Type 69 seems to load again with the above commit:

INFO:velbus-handler:Start module scan
INFO:velbus-handler:Starting handling scan 1
INFO:velbus-handler:Starting scan 1
INFO:velbus:Found module 1: <{} type:69 address:1 loaded:False loading:False channels: {}>
DEBUG:velbus-handler:Module 1 detected: start loading
INFO:velbus-handler:Scan module 1 completed, module loaded=True
...
...
...
INFO:velbus-handler:Module scan completed
<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

<None type:69 address:1 loaded:True loading:False channels: {}>

So does VMBDALI-20 (type:90)

INFO:velbus-handler:Start module scan
INFO:velbus-handler:Starting handling scan 1
INFO:velbus-handler:Starting scan 1
INFO:velbus:Found module 1: <{} type:90 address:1 loaded:False loading:False channels: {}>
DEBUG:velbus-handler:Module 1 detected: start loading
INFO:velbus-handler:Scan module 1 completed, module loaded=True
...
...
...
INFO:velbus-handler:Module scan completed
<None type:90 address:1 loaded:True loading:False channels: {}>

<None type:90 address:1 loaded:True loading:False channels: {}>

<None type:90 address:1 loaded:True loading:False channels: {}>

<None type:90 address:1 loaded:True loading:False channels: {}>