Bugfix vmbdali #115
Merged
Bugfix vmbdali #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cereal2nd
approved these changes
Jul 22, 2024
|
@niobos , can I be of assistance testing VMBDALI and VMBDALI-20 going forward? |
|
I still need to test the changes on an actual installation that has the VMBDALI modules. Currently, I can't access it, but I should be able to in the next few weeks. If you know how to run Home Assistant with a development version of velbus-aio, you can try it and report back. |
|
I can confirm that these changes fix the VMBDALI (1st version, not -20) in my installation. What needs to happen next is that @cereal2nd needs to release a new version of this library, and this new release needs to be referenced from the Home Assistant code. This is fairly straight-forward, but requires some manual work. |
|
the pull-request has been created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: WORK IN PROGRESS
I haven't tested this on my installation yet
This should fix #114.
It also adds a very basic test that should catch this in the future.