This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
fix(flapping) don't flap if host/parents not up #524
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Description
As described in #192, flapping should not be computed when related host (for a service) or parents (for a host) are not up.
It makes more sense, and flapping is only reliable to compute when the related host / parents are up.
This also leads to less unneeded / unwanted notifications.
Fixes #192.
Type of change
Target serie
How this pull request can be tested ?
Enable flapping detection, make a host or service to flap while its related host or parent is down, and be sure it is not flagged as flapping.
Many thanks 👍