Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

fix(flapping) don't flap if host/parents not up #524

Closed
wants to merge 2 commits into from

Conversation

UrBnW
Copy link
Contributor

@UrBnW UrBnW commented Jun 28, 2021

Hi,

Description

As described in #192, flapping should not be computed when related host (for a service) or parents (for a host) are not up.
It makes more sense, and flapping is only reliable to compute when the related host / parents are up.
This also leads to less unneeded / unwanted notifications.
Fixes #192.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 19.10.x
  • 20.04.x
  • 20.10.x
  • 21.04.x
  • 21.10.x (master)

How this pull request can be tested ?

Enable flapping detection, make a host or service to flap while its related host or parent is down, and be sure it is not flagged as flapping.

Many thanks 👍

@UrBnW
Copy link
Contributor Author

UrBnW commented Jul 2, 2021

@bouda1 what's the build issue here ?
So that I can correct it.
Many thanks !
(I don't have access to Jenkins results)

@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@omercier
Copy link
Contributor

omercier commented Aug 4, 2021

Hi @UrBnW,
Would you like to discuss this PR as well as This one with the dev team and myself?
You can reach me at <my pseudo>@centreon.com
Best regards,
Olivier

@UrBnW
Copy link
Contributor Author

UrBnW commented Aug 4, 2021

Hi @omercier,
Sure, thank you for your proposal, let me reach you by mail 👍

@omercier
Copy link
Contributor

Hi,
Thanks a lot for your contribution!
This PR will be processed by our dev team for our 21.10 release.
Regards,
Olivier

@UrBnW
Copy link
Contributor Author

UrBnW commented Aug 10, 2021

Really good news @omercier, then you again for your consideration 👍

@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rem31
Copy link
Contributor

rem31 commented Sep 29, 2021

this pr is fixed by it #557

@rem31 rem31 closed this Sep 29, 2021
@UrBnW UrBnW deleted the flapdependencies branch September 29, 2021 07:52
@UrBnW
Copy link
Contributor Author

UrBnW commented Sep 29, 2021

Absolutely perfect, really glad, thank you @rem31 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not compute flapping state when host / parent is not up
3 participants