Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

fix(flapping): don't start flapping with parent not up #557

Merged
merged 8 commits into from
Sep 29, 2021

Conversation

rem31
Copy link
Contributor

@rem31 rem31 commented Sep 21, 2021

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.04.x
  • 20.10.x
  • 21.04.x
  • 21.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

src/host.cc Outdated Show resolved Hide resolved
src/service.cc Outdated Show resolved Hide resolved
tests/notifications/host_flapping_notification.cc Outdated Show resolved Hide resolved
tests/notifications/host_flapping_notification.cc Outdated Show resolved Hide resolved
tests/notifications/service_flapping_notification.cc Outdated Show resolved Hide resolved
tests/notifications/service_flapping_notification.cc Outdated Show resolved Hide resolved
tests/notifications/service_flapping_notification.cc Outdated Show resolved Hide resolved
@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rem31 rem31 merged commit 56f6219 into develop Sep 29, 2021
@rem31 rem31 deleted the MON-10904-flapping-start-with-parent-up branch September 29, 2021 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants