convert annotations to string values in zipkin reporter #104
Conversation
tsloughter
force-pushed
the
zipkin-annotations
branch
from
dfadae0 to
4e23bef
Compare
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 80.6% 80.62% +0.01%
==========================================
Files 34 34
Lines 696 707 +11
==========================================
+ Hits 561 570 +9
- Misses 135 137 +2
Continue to review full report at Codecov.
|
| uncompressed_size=UncompressedSize, | ||
| compressed_size=CompressedSize}) -> | ||
| iolist_to_binary(["MessageEvent:{type=", atom_to_binary(Type, utf8), | ||
| ", id=", integer_to_binary(Id), |
There was a problem hiding this comment.
integer_to_binary - converts to decimal value or binary? real binary may be hard to read.
There was a problem hiding this comment.
It is more like integer to string. Erlang has a specific binary type. It is used a lot for strings, esp when going to json since regular Erlang strings are just lists of integers and the way most json encoders work in Erlang is to require strings as binaries so it can easily know if you meant a string or an array of integers.
Binaries are also represented with the << and >> syntax you probably see all over the code.
|
do you have tests too? |
|
Adding a test now. |
tsloughter
force-pushed
the
zipkin-annotations
branch
from
4e23bef to
8e9b1f3
Compare
|
Updated with test. |
tsloughter
force-pushed
the
zipkin-annotations
branch
from
8e9b1f3 to
f31b0b7
Compare
No description provided.