-
Notifications
You must be signed in to change notification settings - Fork 38
pointers for getting started #101
Comments
Hi Mark, I don't have a complete example, so will answer just zipkin part.
this is an excerpt from our config. |
Thanks for the help. I have made good progress. However, I am struggling to add an annotation to a span and have it show up in zipkin. But I never see the annotation in zipkin. Any ideas.?? Thanks. Mark. |
@geib so the span shows up in zipkin but without the annotation? |
@tsloughter Yes, and I see attributes as well, just no annotations. |
Haven't had a chance to try reproducing. I'll will try to get to it today or tomorrow. I don't have anything writing to zipkin anymore after switching jobs :). |
we use zipkin. works fine |
@deadtrickster Are you using process-dict contexts or ctx contexts? I am using ctx contexts. |
I'm working on reproducing right now. |
So yea, I also don't see the annotation time event in zipkin. With the stdout reporter I do see that it is correctly added to the span:
Guessing it is in the zipkin conversion that we might be losing it. I'm continuing to investigate. |
Hah, yea, this would do it: https://github.com/census-instrumentation/opencensus-erlang/blob/master/src/oc_reporter_zipkin.erl#L69 :) |
heh, looks like we use our custom branch for too long |
@tsloughter I have the patch now and the changes are working. Thanks. Question: Does the opencensus spec specifiy that the attributes in an annotation are tagged with the string "Attributes". At least in zipkin I expected to see the description, then the attributes as simple key=value pairs. |
@geib the spec was started thanks to this ticket :). census-instrumentation/opencensus-specs#193 So it is still in flux. We discussed it briefly in the opencensus gitter channel. |
@geib, @tsloughter recently sent this change to the website providing quickstarts, which I believe will solve your original issue. Thank you @tsloughter!
|
I am very interested in evaluating opencensus, but need a couple of quick pointers. I plan to create a few spans, some with children spans, and use zipkin for visualizing the spans, etc. I think I have the span creation understood sufficiently, but how I report these to zipkin escapes me. For this eval I want to see every span, so I am using the oc_sampler_always, but I don't see how to report anything to zipkin. Is this done by my code, or a service in opencensus, i.e., do I need to make some call periodically to report spans to zipkin.
Thanks in advance, this looks very exciting.
The text was updated successfully, but these errors were encountered: