Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump web3 from 1.3.4 to 1.3.5 #7684

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Bump web3 from 1.3.4 to 1.3.5 #7684

merged 3 commits into from
Apr 14, 2021

Conversation

yorhodes
Copy link
Contributor

@yorhodes yorhodes commented Apr 13, 2021 •
edited
Loading

Description

Bump web3 version to get rid of annoying warning messages

Tested

CI?

Related issues

Backwards compatibility

See https://github.com/ChainSafe/web3.js/releases/tag/v1.3.5

@yorhodes yorhodes requested a review from a team April 13, 2021 23:49
@yorhodes yorhodes requested a review from a team as a code owner April 13, 2021 23:49
@yorhodes yorhodes changed the title Bump from 1.3.4 to 1.3.5 Bump web3 from 1.3.4 to 1.3.5 Apr 13, 2021
gastonponti
gastonponti suggested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good to me, but I think you added a submodule that shouldn't be there...
packages/cli/6c55a19a88ffa8b1b531c1813af216f0

@yorhodes yorhodes force-pushed the upgrade-web3-1.3.5 branch from 80f3cb6 to 7590873 Compare April 14, 2021 22:07
gastonponti
gastonponti approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorhodes yorhodes added the automerge Have PR merge automatically when checks pass label Apr 14, 2021
@mergify mergify bot merged commit fc51878 into master Apr 14, 2021
@mergify mergify bot deleted the upgrade-web3-1.3.5 branch April 14, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonponti gastonponti gastonponti approved these changes

@asaj asaj Awaiting requested review from asaj

@eelanagaraj eelanagaraj Awaiting requested review from eelanagaraj

@mcortesi mcortesi Awaiting requested review from mcortesi

@medhakothari medhakothari Awaiting requested review from medhakothari

@cmcewen cmcewen Awaiting requested review from cmcewen

@timmoreton timmoreton Awaiting requested review from timmoreton

Assignees
No one assigned
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update web3 to 1.3.5
2 participants
@yorhodes @gastonponti