Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web3 to 1.3.5 #7574

Closed
barbaraliau opened this issue Apr 1, 2021 · 0 comments · Fixed by #7684
Closed

Update web3 to 1.3.5 #7574

barbaraliau opened this issue Apr 1, 2021 · 0 comments · Fixed by #7684
Labels
Applications Applications circle tasks Component: ContractKit Priority: P2 Major

Comments

@barbaraliau
Copy link
Contributor

Expected Behavior

Deprecated package errors should not show up when using web3

Current Behavior

These messages show up, even though we aren't using either of them directly.

web3-shh package will be deprecated in version 1.3.5 and will no longer be supported.
web3-bzz package will be deprecated in version 1.3.5 and will no longer be supported.

This is a known issue and is on the web3 side. There is a release candidate out that fixes these warnings.

web3 houses those two packages. I would imagine that that warning shows up for anyone using web3, so it’s not something that we can control unless we only import just the web3 modules that we use.
web3/web3.js#3898
Looks like if we upgrade to 1.3.5-rc.0 it will get rid of the warning web3/web3.js#3917
@barbaraliau barbaraliau added Applications Applications circle tasks Component: ContractKit labels Apr 1, 2021
@yorhodes yorhodes mentioned this issue Apr 13, 2021
Merged
@mergify mergify bot closed this as completed in #7684 Apr 14, 2021
mergify bot pushed a commit that referenced this issue Apr 14, 2021
@yorhodes
Bump web3 from 1.3.4 to 1.3.5 (#7684)
fc51878 
### Description

Bump web3 version to get rid of annoying warning messages

### Tested

CI?

### Related issues

- Fixes #7574

### Backwards compatibility

See https://github.com/ChainSafe/web3.js/releases/tag/v1.3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Applications Applications circle tasks Component: ContractKit Priority: P2 Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump web3 from 1.3.4 to 1.3.5 celo-org/celo-monorepo
2 participants
@aslawson @barbaraliau