-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blob/trace): cover blob service with traces #3113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd,
walldiss and
ramin
as code owners
January 18, 2024 11:54
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3113 +/- ##
==========================================
+ Coverage 51.84% 51.95% +0.10%
==========================================
Files 178 178
Lines 11239 11262 +23
==========================================
+ Hits 5827 5851 +24
- Misses 4911 4912 +1
+ Partials 501 499 -2 ☔ View full report in Codecov by Sentry. |
ramin
previously approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
distractedm1nd
previously approved these changes
Jan 22, 2024
Wondertan
reviewed
Jan 22, 2024
Wondertan
reviewed
Jan 23, 2024
distractedm1nd
approved these changes
Jan 29, 2024
Wondertan
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover Blob service with Otel traces. Partly fixes #3112