Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(blob): Add trace paths through blob module to trace Read paths #3112

Closed
ramin opened this issue Jan 18, 2024 · 1 comment · Fixed by #3113
Closed

metrics(blob): Add trace paths through blob module to trace Read paths #3112

ramin opened this issue Jan 18, 2024 · 1 comment · Fixed by #3113
Assignees
Labels
area:blob area:metrics Related to measuring/collecting node metrics

Comments

@ramin
Copy link
Contributor

ramin commented Jan 18, 2024

There have been some loose reports of "reads being slow". Though this is vague, a first step is to add traces to the blob module read codepath.

Then we can use a testing tool (such as waypoint) to perform many reads and see what traces are emitted

success:

  • blob module read paths are instruments with traces
  • potentially add some timing metrics too
@ramin ramin added area:metrics Related to measuring/collecting node metrics area:blob labels Jan 18, 2024
Wondertan pushed a commit that referenced this issue Jan 30, 2024
Cover Blob service with Otel traces. Partly fixes #3112
@Wondertan
Copy link
Member

@vgonkivs and @ramin, can we say it's closed or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob area:metrics Related to measuring/collecting node metrics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants