-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: remove iavl #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 60.33% 60.87% +0.53%
==========================================
Files 262 261 -1
Lines 23888 23642 -246
==========================================
- Hits 14414 14393 -21
+ Misses 7979 7757 -222
+ Partials 1495 1492 -3
|
@@ -31,9 +32,11 @@ require ( | |||
github.com/spf13/cobra v1.1.1 | |||
github.com/spf13/viper v1.7.1 | |||
github.com/stretchr/testify v1.6.1 | |||
github.com/tendermint/tendermint v0.34.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
light/rpc/client_test.go
Outdated
// require.NoError(t, err) | ||
|
||
// assert.NotNil(t, res) | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the rationale behind commenting this out vs. deleting the code? Also, I think testOpDecoder
and testOp
below can be removed or commented out, too.
@evan-forbes can you add an equivalent test into the app repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to leave it around as an example. I can remove
P.S. The sdk doenst have the notion of a light client, it first needs to be added (cosmos/cosmos-sdk#6563)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think removing makes sense. We can link to the still existing code in the tendermint repo in an issue (over in the app repo or here). Thanks for the context regarding the light client 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As expected, there's no "github.com/tendermint/tendermint" in the go mod graph
results 👍
While using the replace directive on this branch in the cosmos-sdk fork still produces the same error as before, manually replacing tendermint with lazyledger-core does work! Most, but not all, of the tests fail to build, some of which is due to the PreprocessTxs
method to the ABCI interface not yet being ported to the fork of the cosmos-sdk.
thanks, @marbar3778, for fixing this, and saving me from trying an overly complex fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this so quickly Marko!
LGTM
Want to enable auto deleting of branches after merges? |
I think it is already on. I think this does not impact branches in PRs from forks. |
Description
Remove IAVL as a dependency to prevent circular dependencies in ll-app
Closes: #128