-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorporate tendermint light client #6563
Comments
I agree here, but are there any actionable items aside from removing |
the actionable would be to create a command that initiates a light client and docs surrounding this |
Gotcha. Ok, so we want to create a command that starts a light-client daemon. That sounds reasonable to me :) |
Just to be clear, this isn't slated for Stargate atm, which means clients will not be able to verify proofs. If they make queries against their own nodes (which is the default behavior), then I think this might be OK for now. |
Could this be added in a patch release(minor), 0.40.1? I know its a new feature but could be useful |
Possibly, yes. |
q: what's the status of this issue? should we add it to the next release? |
it can be added at anytime. Someone needs to implement this https://github.com/tendermint/tendermint/blob/master/cmd/tendermint/commands/light.go into the sdk. Not sure if anyone has taken ownership of this |
@marbar3778 @alexanderbez I can see there is a PR #9155 about adding a light client daemon, but it was closed for some reasons without being merged. Are there any plans to merge it? Are there any plans to support light client and proof verification within CLI? |
AFAIK, the light client is implemented in Tendermint core. |
so this issue may help us remove the dependence on tendermint in store. there are two other items we would need, but tendermint light client technically doesn't work for verification of sdk state without running the sdk. |
Summary
As I am going through updating the SDK to the latest Tendermint version there have been countless changes. One, in particular, is the trust node feature. This feature allowed users to set a flag in the cli to trust the node they are sending their txs to. This feature used various functions from Tendermint to verify that the information received from a node was valid. In 0.34 of Tendermint some of these features are no longer present.
Proposal
Remove the trust node feature and get the user to use a light client. If a user is not a full node then they have the option to spin up a light client and interact through it, otherwise, they will not be able to trust the node they are speaking with
The new light client from Tendermint is efficient enough to catch up in a short period of time.
@alexanderbez do you have anything to add
For Admin Use
The text was updated successfully, but these errors were encountered: