Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporate tendermint light client #6563

Closed
2 of 4 tasks
tac0turtle opened this issue Jul 1, 2020 · 11 comments
Closed
2 of 4 tasks

incorporate tendermint light client #6563

tac0turtle opened this issue Jul 1, 2020 · 11 comments

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jul 1, 2020

Summary

As I am going through updating the SDK to the latest Tendermint version there have been countless changes. One, in particular, is the trust node feature. This feature allowed users to set a flag in the cli to trust the node they are sending their txs to. This feature used various functions from Tendermint to verify that the information received from a node was valid. In 0.34 of Tendermint some of these features are no longer present.

Proposal

Remove the trust node feature and get the user to use a light client. If a user is not a full node then they have the option to spin up a light client and interact through it, otherwise, they will not be able to trust the node they are speaking with

The new light client from Tendermint is efficient enough to catch up in a short period of time.

@alexanderbez do you have anything to add


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

I agree here, but are there any actionable items aside from removing trust-node, which is already done in #6554? If not, then I don't think we need this issue.

@tac0turtle
Copy link
Member Author

the actionable would be to create a command that initiates a light client and docs surrounding this

@alexanderbez
Copy link
Contributor

Gotcha. Ok, so we want to create a command that starts a light-client daemon. That sounds reasonable to me :)

@alexanderbez
Copy link
Contributor

Just to be clear, this isn't slated for Stargate atm, which means clients will not be able to verify proofs. If they make queries against their own nodes (which is the default behavior), then I think this might be OK for now.

@tac0turtle
Copy link
Member Author

tac0turtle commented Jul 21, 2020

Could this be added in a patch release(minor), 0.40.1? I know its a new feature but could be useful

@alexanderbez
Copy link
Contributor

Possibly, yes.

@fedekunze
Copy link
Collaborator

q: what's the status of this issue? should we add it to the next release?

@tac0turtle
Copy link
Member Author

tac0turtle commented Mar 29, 2021

it can be added at anytime. Someone needs to implement this https://github.com/tendermint/tendermint/blob/master/cmd/tendermint/commands/light.go into the sdk.

Not sure if anyone has taken ownership of this

@ashcherbakov
Copy link

@marbar3778 @alexanderbez
Can you please help us to understand the status of the light client feature in cosmos? We do need this feature for our apps.
In particular, are there any plans to verify the proofs in CLI? As I can see, currently CLI doesn't verify any proof (see link), so generally speaking, if it's connected to a node that we don't control, we can not trust the results of CLI.

I can see there is a PR #9155 about adding a light client daemon, but it was closed for some reasons without being merged. Are there any plans to merge it? Are there any plans to support light client and proof verification within CLI?

@alexanderbez
Copy link
Contributor

AFAIK, the light client is implemented in Tendermint core.

@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 9, 2022
@tac0turtle
Copy link
Member Author

so this issue may help us remove the dependence on tendermint in store. there are two other items we would need, but tendermint light client technically doesn't work for verification of sdk state without running the sdk.

@tac0turtle tac0turtle removed their assignment Aug 30, 2023
@tac0turtle tac0turtle moved this to 👀 To Do in Cosmos-SDK Nov 16, 2023
@tac0turtle tac0turtle moved this from 👀 To Do to ❌ Blocked in Cosmos-SDK Nov 16, 2023
@tac0turtle tac0turtle moved this from ❌ Blocked to 🧑‍🔧 Needs Design in Cosmos-SDK Nov 16, 2023
@tac0turtle tac0turtle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@github-project-automation github-project-automation bot moved this from ☃️ Icebox to 🥳 Done in Cosmos-SDK Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

6 participants