Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 001 ABCI++ #231

Merged
merged 34 commits into from
Apr 10, 2022
Merged

ADR 001 ABCI++ #231

merged 34 commits into from
Apr 10, 2022

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Mar 3, 2022

Description

Here's the ADR for all things ABCI++ rendered

closes #156

Here are the references mentioned in the ADR so that github can better track them

Issues that will be able to be closed after merging this and all implemetation PRs

#77
#454
#520
#626
#636
#156
#204

Open PRs in order of which need to be reviewed/merged first

#631
#637
cut a new release of core
#63
cut a new realese of the sdk
#214
#216
#224
cut a new release of the app

Other related by unmerged ADRs that we can close after merging this ADR

#559
#157

@evan-forbes evan-forbes self-assigned this Mar 3, 2022
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but overall looks fine to me

docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
evan-forbes and others added 3 commits March 7, 2022 12:59
Co-authored-by: John Adler <[email protected]>
Co-authored-by: John Adler <[email protected]>
Co-authored-by: John Adler <[email protected]>
adlerjohn
adlerjohn previously approved these changes Mar 7, 2022
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but I'm probably not the best to review this

rach-id
rach-id previously approved these changes Mar 7, 2022
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 👍

docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
Co-authored-by: CHAMI Rachid <[email protected]>
@evan-forbes evan-forbes dismissed stale reviews from rach-id and adlerjohn via b6e9737 March 9, 2022 15:29
Co-authored-by: CHAMI Rachid <[email protected]>
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited about this! Left some comments.

docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to be merged!

@evan-forbes
Copy link
Member Author

really sorry for the delay on incorporating feed back in this PR... I think I lost this PR on my radar for a while.

@evan-forbes evan-forbes requested review from liamsi and rach-id April 4, 2022 12:21
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetics

docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
evan-forbes and others added 10 commits April 4, 2022 11:04
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
Co-authored-by: CHAMI Rachid <[email protected]>
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
docs/architecture/ADR-001-ABCI++.md Outdated Show resolved Hide resolved
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this

evan-forbes and others added 3 commits April 10, 2022 10:48
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Evan!!

@evan-forbes evan-forbes merged commit 67ae66f into master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ADR for switching to ABCI++ early
4 participants