ADR001: Adopt ABCI++ Early #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2021
Closed
|
Over break, I've been thinking about slightly revising this ADR. I still think we should work on all the things that don't need ABCI++ first, such as fixing the cli and tracking WirePayForMessages, but after, if ABCI++ is not yet finished, we would help push ABCI++ over the finish line instead of investing efforts into adopting prematurely. |
|
I think we can close this PR, as we should no longer have to go out of our way to adopt ABCI++ early |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADR that describes the options we have to adopt ABCI++ early. The whole point of this ADR is to emphasize that we are in a difficult situation. ABCI++ enables us to fix most of our issues in a non hacky way, but it is also not finished yet. We could implement hacky solutions instead of waiting for ABCI++, only to reimplement the same things in a less hacky way as soon as ABCI++ comes out.
rendered
closes: #156