Fixing popup focus behavior and DPI transform bug. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brock8503
changed the title
|
@perlun Let me know how I can help move this along. This is actually a blocker for me and my team. |
|
Sorry, haven't had time to look at it yet. |
|
@jornh, could you do me a favor and check if this works correctly for you (given my current lack of time etc)? You can then merge at will. TIA. |
jornh
added a commit
that referenced
this pull request
Apr 29, 2014
Fixing #213 popup focus behavior and DPI transform bug.
|
Tested on http://www.tutorialspoint.com/html/html_select_tag.htm at 125% DPI setting. Works as intended. Merging now, thanks @brock8503! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the popup behavior and dpi bug
Popups did not behave the same as chrome popup because of how the mouse was captured. I needed to add custom events to mousein and mouseout on the popup to set focus and capture mouse on the popup hwnd instead of the parent.
#213 - Simply refactoring a little and adding the transform to the popup on creation fixed the scaling issues when the window DPI was changed.
(PS. separating pull request in #313)