Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-down list (<select>) not displayed correctly in WPF with 125% or 150% display setting #213

Closed
ta-stott-oe opened this issue Nov 12, 2013 · 9 comments
Labels
bug cef3 wpf WPF Implementation
Milestone

Comments

@ta-stott-oe
Copy link
Contributor

With Display Settings on 125% or 150%, the drop-down part of a select element is displayed with the incorrect size and position. This applies to v1.25.5.0

@ta-stott-oe
Copy link
Contributor Author

I think this happens because the scale transformation used when there is a non-standard DPI setting isn't applied to popups. I had a poke around in CefSharp.Wpf/WebView.cpp and found I could (apparently) fix the drop-downs by applying the result of GetScaleTransform() to _popup and to the offsets used in SetPopupSizeAndPosition().

@perlun
Copy link
Member

perlun commented Nov 12, 2013

Hi,

We have seen this at a customer site using Windows 8, but I haven't had time to look into it yet. Care to make a PR out of it? It would be great! Many thanks in advance.

ta-stott-oe added a commit to ta-stott-oe/CefSharp that referenced this issue Nov 14, 2013
…e layout and offset transforms to popup when display setting has non-standard DPI
perlun added a commit that referenced this issue Nov 19, 2013
Proposed fix for issue #213 (for CefSharp1 only).
@perlun
Copy link
Member

perlun commented Nov 19, 2013

Re-targetting CefSharp3 now, so it's not forgotten.

@perlun
Copy link
Member

perlun commented Nov 19, 2013

Also related to #166. But should probably be fixed after #194.

@JanEggers
Copy link
Contributor

@perlun this one may be closed as well, as #166 is fixed

or did i miss something?

@perlun
Copy link
Member

perlun commented Mar 21, 2014

@JanEggers, they are related but not 100% the same. We should verify that it works w/ CefSharp3 before closing I'd say. If you like, give it a try (by switching DPI in Windows) and see if they are positioned correctly.

@perlun
Copy link
Member

perlun commented Mar 21, 2014

Take a look at this line. I'm note sure it's entirely relevant though (since I changed the dropdowns to work slightly differently on CefSharp3 compared to CefSharp1), so please investigate if you have time and remove the comments if it does work right.

brock8503 added a commit to brock8503/CefSharp that referenced this issue Apr 13, 2014
@brock8503
Copy link
Contributor

@perlun I think I cracked the issue, we did need to add similar transformation to the popup to make sure it scaled correctly.

@perlun perlun modified the milestones: 31.0.0, 31.0.0-pre1 Apr 15, 2014
brock8503 added a commit to brock8503/CefSharp that referenced this issue Apr 21, 2014
brock8503 added a commit to brock8503/CefSharp that referenced this issue Apr 21, 2014
jornh added a commit that referenced this issue Apr 29, 2014
Fixing #213 popup focus behavior and DPI transform bug.
@jornh
Copy link
Contributor

jornh commented Apr 29, 2014

Closed with merge of #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cef3 wpf WPF Implementation
Projects
None yet
Development

No branches or pull requests

5 participants