Upgraded to CEF 62 #2203
Merged
Upgraded to CEF 62 #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabzIt
approved these changes
Nov 27, 2017
There was a problem hiding this comment.
Looks good!! Just for any release notes it doesn't look like there is any replacements for LocationBarVisible, Resizable, Fullscreen and Dialog: https://bitbucket.org/chromiumembedded/cef/src/master/include/internal/cef_types.h?fileviewer=file-view-default#cef_types.h-1923
perlun
force-pushed
the
feature/support-cef-62
branch
from
85c2adf to
bd8943a
Compare
perlun
force-pushed
the
feature/support-cef-62
branch
from
bd8943a to
6a850e1
Compare
This was referenced Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to chime in - fixes part of #2200. 🎉
The issue with JS bindings being lost have not been sorted out in this PR, I intend to look at that in a separate PR before we do the release. This compiles and runs for me, and looks pretty neat: