Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CEF 3.3202.1686.gd665578 / Chromium 62 #2200

Closed
2 of 4 tasks
perlun opened this issue Nov 17, 2017 · 27 comments
Closed
2 of 4 tasks

Support CEF 3.3202.1686.gd665578 / Chromium 62 #2200

perlun opened this issue Nov 17, 2017 · 27 comments
Milestone

Comments

@perlun
Copy link
Member

perlun commented Nov 17, 2017

This is an umbrella release to support the Chromium 62 version in CefSharp, which I think a lot of you are waiting for.

Some of the known issues thus far:

Fixes we get for free because of the upgrade:


Update: Prerelease packages are available on nuget.org, please ensure to check the "Include prereleases" checkbox in the NuGet settings in Visual Studio.

@mjbrookecub
Copy link

Hiya, any ideas on when this is likely to be ready? I've found a bug with the version of cef that v57 is using and am looking forward to that being resolved.

@perlun
Copy link
Member Author

perlun commented Nov 27, 2017

Hiya, any ideas on when this is likely to be ready?

ASAP. 😄 Hopefully rather soon, but because of the nature of the project it's difficult to make promises at this stage. We'll let you and everyone else eagerly waiting know as soon as it's ready, for sure.

@jankurianski jankurianski added this to the 62.0.0 milestone Nov 29, 2017
@SilverDragon135
Copy link

CEF 62 probably fixes #1916 too.
I had scrolling problems in winforms too in case I was scrolling during the loading - fixed with CEF 62 for me.

@perlun
Copy link
Member Author

perlun commented Dec 2, 2017

Thanks @SilverDragon135, added it to the list.

@perlun
Copy link
Member Author

perlun commented Dec 9, 2017

Chrome 63 was recently released. We should probably re-target this to go with CEF 63 instead.

If someone wants to do the initial work of bringing it into cef-binary, by all means, be my guest!

@muffmolch
Copy link

thus.. no cefsharp for 62?

@perlun
Copy link
Member Author

perlun commented Dec 12, 2017

thus.. no cefsharp for 62?

Not yet, no. We could make a release but it still has the #1203 bug present which will prevent some people from using it.

Please vote on this comment: 👎 if you want to have a 62 release asap, or 👍 if you'd rather wait some extra time but get a 63 release instead. Nothing is free in this world, everything takes a bit of time and it would be nice to hear your feedback before spending time on this.

I will base my decision on your feedback. I personally would prefer the 63 approach (since it seems silly to release a version which is already outdated at the time of release), but I'm very open to your opinions also.

@Cansii
Copy link

Cansii commented Dec 12, 2017

Current Cefsharp release version (57) have stability issue (probably #2170) so we got many stabily issues on our latest product version. It may leads to security issue for ours systems, so I realy hope you can release new stable version soon.
If not, I have to revert to last realy stable release (53 for me).
Thanks a lot for your great job.

@muffmolch
Copy link

question is: is version 63 really uptodate when the new CEFVersion gets released ;-)

@perlun
Copy link
Member Author

perlun commented Dec 12, 2017

@Cansii

Current Cefsharp release version (57) have stability issue (probably #2170) so we got many stabily issues on our latest product version. It may leads to security issue for ours systems, so I realy hope you can release new stable version soon.

Stability issues is one thing, I know about #2170, but security issues? Are we not mixing things up a bit here?

I understand if people have problems with 57, that's fine. I think bumping the release to use 63 doesn't really have to be that much work to be honest though, so I am leaning towards that route since everyone will thank me for doing so in the long run... 😉

@Cansii
Copy link

Cansii commented Dec 12, 2017

@perlun

Stability issues is one thing, I know about #2170, but security issues? Are we not mixing things up a bit here?

As I said, stabilty issue leads to some security issues in my product. Uncatchable exceptions lead to a app crash. And my app need to be running continuously (to ensure kiosk mode).

So, I probably have to reingeneer my app architecture, but this is not a mixing...

I agree, in the long run, 63 is better.

You know the time cost of this choice. But you ask, so I give you my anser. ;)

@perlun
Copy link
Member Author

perlun commented Dec 12, 2017

You know the time cost of this choice. But you ask, so I give you my anser. ;)

That's fine. 😄 I understand your concerns, thanks for using CefSharp.

I noticed that CEF 63 isn't yet available at http://opensource.spotify.com/cefbuilds/index.html, so let's go with a CefSharp 62 (pre)release instead. Will try to get it done within the next few days.

@Cansii
Copy link

Cansii commented Dec 12, 2017

Will try to get it done within the next few days.
Great !

Maybe could you give me a trick about a way to catch this uncatchable exception ?

@perlun
Copy link
Member Author

perlun commented Dec 12, 2017

@Cansii Let's move that discussion to Gitter or a separate issue. If it's exceptions being raised on the C++ side, I think the unfortunate answer is that they cannot be caught. But, as stated, let's move that part of the discussion elsewhere.

@perlun
Copy link
Member Author

perlun commented Dec 12, 2017

@Cansii and others - a first 62.0.0 prerelease is now available: https://github.com/cefsharp/CefSharp/releases/tag/v62.0.0-pre01

Please test it and give us your feedback here in this issue.

@mjbrookecub
Copy link

It seems to work really well for me. Solves two of the issues I had with v57

@muffmolch
Copy link

It's fine on our side, too! Thanks a lot!

@vwmberry95
Copy link
Contributor

Any plans for another build with proprietary codecs? I have "62.0.0-CI2368" installed, if I try to update CefSharp.Common and CefSharp.Wpf to "62.0.0-pre01" I get this message:

Unable to resolve dependencies. 'cef.redist.x86 3.3202.1690-proprietary-codecs' is not compatible with 'CefSharp.Common 62.0.0-pre01 constraint: cef.redist.x86 (= 3.3202.1686)'.

I can roll with "62.0.0-CI2368" as it's working great, I was just hoping to test "62.0.0-pre01" for you as well while keeping H.264 support.

Greatly appreciated as always!

@mitchcapper
Copy link
Contributor

@vwmberry95 there are potential licensing issues with proprietary codecs so it will likely not be in the official tree. You can compile from scratch yourself these features in although it is tedious. As for the errors if you run into it on the current nuget packages it may be due to installing the former 62 test which had those dependencies and left elements in your project file. Remove cefsharp from your project and save the project file. Open the project file in a text editor and remove any cef references (you may find older versions as well). Then installing 62.0.0-pre01 should work.

@vwmberry95
Copy link
Contributor

@mitchcapper Thanks, mitch. Yeah, I should have targeted that comment towards @perlun as he did the build with codecs under the myget tree due to licensing as you said. Being so tedious, having it done once in a fashion that correlates with the CefSharp release would be greatly appreciated by many, I'm sure.

That being said, I did try building from scratch in the past but had issues, perhaps because CefSharp was still targeting v57 at the time. Even building cef at the same version had issues.

@perlun
Copy link
Member Author

perlun commented Dec 15, 2017

@mitchcapper Thanks, mitch. Yeah, I should have targeted that comment towards @perlun as he did the build with codecs under the myget tree due to licensing as you said. Being so tedious, having it done once in a fashion that correlates with the CefSharp release would be greatly appreciated by many, I'm sure.

Yeah, like @mitchcapper mentioned I think it will be hard to include that code in the official tree (unfortunately!). What we could perhaps do is to make the official packages be runnable towards either version of the cef.redist or something... I don't know. Maybe something like Debian did with their "non-US" files years ago (if anyone remember, back in the days when cryptography was very patent/etc-encumbered... before the US relaxed these restrictions.)

(In other words: I don't have a clear plan for this at the moment. Right now #1203 kind of blocks us from doing a stable CefSharp 62 release anyway, so you can choose between "two different prereleases" at the moment - one "official" and one "unofficial".)

@gusowski1
Copy link

@perlun why does #1203 blocks the release?
As far as i see is issue #1203 open since 2015 - wouldn't it be better to release CefSharp 62 from an security aspect and fix #1203 afterwards and make a 62. release (or 63)

@perlun
Copy link
Member Author

perlun commented Dec 16, 2017

@perlun why does #1203 blocks the release?

Because we anticipate so many people would upgrade to 62.0.0 and have problems because of it, since people (unfortunately) tend to upgrade without reading release notes carefully enough, etc...

So the expectancy is that it will cause more problems for people than it would solve.

As far as i see is issue #1203 open since 2015 - wouldn't it be better to release CefSharp 62 from an security aspect and fix #1203 afterwards and make a 62. release (or 63)

The long story:

  • We have had a workaround in place since September 24 2015 via dcf4eb4 (fixed by @amaitland)
  • In CEF 3029 (CEF 58), the workaround stopped working because of changes upstream.
  • This is one of the main reasons why there hasn't been any stable release of CefSharp since CefSharp 57.0.0. We haven't been able to implement a proper workaround for this yet, unfortunately. (mostly because of lack of time/resources to work on the project.)

If all goes well and @amaitland gets enough funding, #1203 will be sorted out in the quite near future: https://gist.github.com/amaitland/91dae9ecfe8c47d0da08e000685eeef2


We can always have a vote: use the 👍 on this comment if you want to see us release a 62.0.0 asap with the bug present (and perhaps a setting flag like Alex suggested to make people be aware of it and "opt in" to "JS bindings with defect").

Use the 👎 if you rather prefer to wait on a 62.0.0 or 63.0.0 until the bug is fixed. We do take our user feedback very seriously, and if we get a reasonable enough amount of feedback on this, we will base the decision on this feedback. Thanks!

@mrtylerzhou
Copy link

63 is available now

@Cansii
Copy link

Cansii commented Jan 4, 2018

@perlun - a first 62.0.0 prerelease is now available:
Please test it and give us your feedback here in this issue.

So I made a test with pre-release nuget package :

  • x64
  • Chromium 62.0.3202.94
  • CEF : r3.3202.1686.gd665578
  • CefSharp : 59.0.0.0

and catching UnhandledException with UnhandledExceptionEventHandler to restart my app.

It seems really better for last 12 hours. But I will wait some times before putting it on most critical install.

And I've got an issue on a particular install (it does not happen on mine) on a particular page with a video. The webm video plays well but the rest of the page is'nt displayed (maybe hidden). I've enought time to get more details at this time. I will investigate this as soon as possible.

@amaitland
Copy link
Member

63.0.0-pre01 packages are on Nuget.org, see https://github.com/cefsharp/CefSharp/releases/tag/v63.0.0-pre01 for the release notes.

Closing this issue as 62 is no longer supported upstream.

@perlun
Copy link
Member Author

perlun commented Jan 8, 2018

Thanks @amaitland. Just to make things clear on everyone, the JS Bindings issue is still not resolved in the published packages - we're tracking that one in #1203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests