Skip to content

Commit

Permalink
Remove Legacy Swiftshader
Browse files Browse the repository at this point in the history
- Update readme files
- Remove from targets
- Remove text references

Issue #4085
  • Loading branch information
amaitland committed May 24, 2022
1 parent 0c62893 commit 61f5813
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 85 deletions.
23 changes: 1 addition & 22 deletions CefSharp.AfterBuild.targets
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</Target>

<!--
Include swiftshader and locales in the Example projects
Include locales in the Example projects
-->
<Choose>
<When Condition="$(RuntimeIdentifier.StartsWith('win')) and $(RuntimeIdentifier.Contains('-x64'))">
Expand All @@ -29,13 +29,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWin64SwiftShader)">
<Link>swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
</ItemGroup>
</When>
<When Condition="$(RuntimeIdentifier.StartsWith('win')) and $(RuntimeIdentifier.Contains('-x86'))">
Expand All @@ -47,13 +40,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWin32SwiftShader)">
<Link>swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
</ItemGroup>
</When>
<When Condition="$(RuntimeIdentifier.StartsWith('win')) and $(RuntimeIdentifier.Contains('-arm64'))">
Expand All @@ -65,13 +51,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWinArm64SwiftShader)">
<Link>swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
</ItemGroup>
</When>
</Choose>
Expand Down
7 changes: 3 additions & 4 deletions CefSharp.Core/CefSettingsBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ public void RegisterScheme(CefCustomScheme scheme)

/// <summary>
/// Set command line argument to disable GPU Acceleration. WebGL will use
/// software rendering via Swiftshader (https://swiftshader.googlesource.com/SwiftShader#introduction)
/// software rendering
/// </summary>
public void DisableGpuAcceleration()
{
Expand All @@ -435,9 +435,8 @@ public void EnablePrintPreview()
}

/// <summary>
/// Set command line arguments for best OSR (Offscreen and WPF) Rendering performance Swiftshader will be used for WebGL, look at the source
/// to determine which flags best suite your requirements. See https://swiftshader.googlesource.com/SwiftShader#introduction for
/// details on Swiftshader
/// Set command line arguments for best OSR (Offscreen and WPF) Rendering performance Software Rendering will be used for WebGL, look at the source
/// to determine which flags best suite your requirements.
/// </summary>
public void SetOffScreenRenderingBestPerformanceArgs()
{
Expand Down
16 changes: 1 addition & 15 deletions CefSharp.Native.props
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</Target>

<!--
Include swiftshader and locales in the Example projects
Include locales in the Example projects
-->
<Choose>
<When Condition="'$(Platform)' == 'x64'">
Expand All @@ -21,13 +21,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWin64SwiftShader)">
<Link>swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
</ItemGroup>
</When>
<When Condition="'$(Platform)' == 'x86' OR '$(Platform)' == 'Win32'">
Expand All @@ -39,13 +32,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWin32SwiftShader)">
<Link>swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
</ItemGroup>
</When>
</Choose>
Expand Down
42 changes: 0 additions & 42 deletions NuGet/PackageReference/CefSharp.Common.NETCore.targets
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWin64SwiftShader)">
<Link>swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
</ItemGroup>
</When>
<When Condition="'$(CefSharpRuntimeIdentifier)' == 'win-x86'">
Expand All @@ -124,13 +117,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWin32SwiftShader)">
<Link>swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
</ItemGroup>
</When>
<When Condition="'$(CefSharpRuntimeIdentifier)' == 'win-arm64'">
Expand All @@ -142,13 +128,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWinArm64SwiftShader)">
<Link>swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
</ItemGroup>
</When>
<Otherwise>
Expand All @@ -163,13 +142,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWin32SwiftShader)">
<Link>runtimes\win-x86\native\swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="$(MSBuildThisFileDirectory)..\runtimes\win-x86\lib\netcoreapp3.1\CefSharp.dll">
<Link>runtimes\win-x86\native\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
Expand All @@ -192,13 +164,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWin64SwiftShader)">
<Link>runtimes\win-x64\native\swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="$(MSBuildThisFileDirectory)..\runtimes\win-x64\lib\netcoreapp3.1\CefSharp.dll">
<Link>runtimes\win-x64\native\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
Expand All @@ -221,13 +186,6 @@
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="@(CefRuntimeWinArm64SwiftShader)">
<Link>runtimes\win-arm64\native\swiftshader\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<PublishState>Included</PublishState>
<Visible>false</Visible>
<IncludeInVsix>true</IncludeInVsix>
</Content>
<Content Include="$(MSBuildThisFileDirectory)..\runtimes\win-arm64\lib\netcoreapp3.1\CefSharp.dll">
<Link>runtimes\win-arm64\native\%(RecursiveDir)%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
Expand Down
2 changes: 1 addition & 1 deletion NuGet/PackageReference/Readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Basic Troubleshooting:
* icudtl.dat (Unicode Support data)
* chrome_elf.dll(Crash reporting library)
* snapshot_blob.bin, v8_context_snapshot.bin (V8 snapshot data)
* locales\en-US.pak, chrome_100_percent.pak, chrome_200_percent.pak, resources.pak, d3dcompiler_47.dll, libEGL.dll, libGLESv2.dll, swiftshader/libEGL.dll, swiftshader/libGLESv2.dll
* locales\en-US.pak, chrome_100_percent.pak, chrome_200_percent.pak, resources.pak, d3dcompiler_47.dll, libEGL.dll, libGLESv2.dll
- Whilst these are technically listed as optional, the browser is unlikely to function without these files.
- See https://github.com/cefsharp/CefSharp/wiki/Output-files-description-table-%28Redistribution%29 for details
* Ijwhost.dll (To support C++/CLI libraries in .NET Core/.Net 5.0, ijwhost was created as a shim for finding and loading the runtime.)
Expand Down
2 changes: 1 addition & 1 deletion NuGet/Readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Basic Troubleshooting:
* icudtl.dat (Unicode Support data)
* chrome_elf.dll(Crash reporting library)
* snapshot_blob.bin, v8_context_snapshot.bin (V8 snapshot data)
* locales\en-US.pak, chrome_100_percent.pak, chrome_200_percent.pak, resources.pak, d3dcompiler_47.dll, libEGL.dll, libGLESv2.dll, swiftshader/libEGL.dll, swiftshader/libGLESv2.dll
* locales\en-US.pak, chrome_100_percent.pak, chrome_200_percent.pak, resources.pak, d3dcompiler_47.dll, libEGL.dll, libGLESv2.dll
- Whilst these are technically listed as optional, the browser is unlikely to function without these files.
- See https://github.com/cefsharp/CefSharp/wiki/Output-files-description-table-%28Redistribution%29 for details
* CefSharp.Core.dll, CefSharp.dll, CefSharp.Core.Runtime.dll
Expand Down

0 comments on commit 61f5813

Please sign in to comment.