Bring back the blocked list and a few others #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo box. Moved a few others over from legacy details element too
…her and fix #1730 by using the test label instead of device if it's been set
|
Thank you, @tkadlec & @scottjehl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out a few things were all lumped together here, so I made a few changes here.
First, it brings back the list of blocked strings and blocked domains, if any were set, closing #1736. Second, it adds the connectivity information (packet loss rate, bandwidth, latency) to the more info section. Finally, it closes #1730 by checking to see if there's a test label and, if so, using it instead of the device type to identify the test.
It also complete eliminates the hidden details that was lurking about, keeping things a bit tidier.
Before:
After:
