Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test label is not shown on details page #1730

Closed
sergeychernyshev opened this issue Feb 4, 2022 · 1 comment · Fixed by #1737
Closed

Test label is not shown on details page #1730

sergeychernyshev opened this issue Feb 4, 2022 · 1 comment · Fixed by #1737
Assignees
Labels
Type: Bug An issue or pull request relating to a bug in WebPageTest

Comments

@sergeychernyshev
Copy link

Description

Test label is no longer visible in the header of the details page which mostly makes it impossible to distinguish one test from another.

Label text is in HTML inside of <details class="heading_details"> which is hidden using CSS:

.heading_details {
    font-size: 0.875em;
    display: none;
    /* TODO TODO */
}

Please do the TODO ;)

Steps to reproduce

Run a test with a label (bottom of the first panel of advanced settings), observe details page, fail to find the label text on the page

Expected result

Label is visible next to the rest of the identifying information.

Actual result

Label is not visible
2022-02-03_23-29-38

@sergeychernyshev sergeychernyshev added the Type: Bug An issue or pull request relating to a bug in WebPageTest label Feb 4, 2022
@scottjehl scottjehl self-assigned this Feb 4, 2022
@scottjehl
Copy link
Contributor

Thanks! Looks like we'd missed this one near the end. I think we could swap out the mobile/desktop labels when there's a custom one, but we'll try some things to get it in all results headers.

tkadlec added a commit that referenced this issue Feb 4, 2022
…her and fix #1730 by using the test label instead of device if it's been set
jefflembeck pushed a commit that referenced this issue Feb 8, 2022
…her and fix #1730 by using the test label instead of device if it's been set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug An issue or pull request relating to a bug in WebPageTest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants