Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include some of the sister extension metadata #7

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alessandratrapani
Copy link
Collaborator

@alessandratrapani alessandratrapani commented Nov 22, 2023

This PR is to refine the previous implementation #5:

ndx-patterned-ogen (1)

  • change names of the following datatype:
    • HolographicSeries --> PatternedOptogeneticSeries
    • HolographicStimulusSite --> PatternedOptogeneticStimulusSite
    • HolographicStimulusPattern --> OptogeneticStimulusPattern
  • Add SpatialLightModulator and LightSource as in suggested in Merge and collaborate with sister extension #6
  • Add common properties of the stimulus pattern to OptogeneticStimulusPattern :
    • duration
    • number_of_stimulus_presentation
    • inter_stimulus_interval
  • Refine names for properties of SpiralScanning and TemporalFocusing
  • Add pattern table and index
  • example files that use this structure from both the mouse V1 and Pinto lab

@CodyCBakerPhD
Copy link
Member

@alessandratrapani So to confirm - this PR is considered a replacement for #5 and #2?

Overall everything looks good IMO but to absolutely clarify it would be great to get example files that use this structure from both the mouse V1 and Pinto lab

And then schedule a meeting with the Histed group to get their take on the aspects of ours that generalize, and if they'd like to help prepare the NEP document

@alessandratrapani
Copy link
Collaborator Author

alessandratrapani commented Nov 23, 2023

So to confirm - this PR is considered a replacement for #5 and #2?

Yes, I didn't want to touch #5 since it's working as it is and if we want to go back to the previous implementation, I have a working branch for that.
Different for #2 that could be closed and replaced by #5, I think.

Overall everything looks good IMO but to absolutely clarify it would be great to get example files that use this structure from both the mouse V1 and Pinto lab

adding this to the TODO list.

@weiglszonja
Copy link
Contributor

@alessandratrapani can you address these if you agree:

  • fix typo stimulation_wavelenght to stimulation_wavelength
  • choose different name for "filter" shadows built-in filter object

@CodyCBakerPhD CodyCBakerPhD marked this pull request as draft December 7, 2023 16:22
@CodyCBakerPhD CodyCBakerPhD changed the base branch from main to no_pattern_table December 7, 2023 16:24
@CodyCBakerPhD
Copy link
Member

State of this PR: this branch will serve only as an example of how our structure might or could be eventually extended further with minimal effort to account for more dynamic pattern presentations over time

However, #7 is the more concise and efficient description of association of patterned stimulation over time per pattern type

Base automatically changed from no_pattern_table to main December 18, 2023 14:46
@CodyCBakerPhD
Copy link
Member

@alessandratrapani Can you fix these merge conflicts when you get a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants