-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include some of the sister extension metadata #7
base: main
Are you sure you want to change the base?
Conversation
@alessandratrapani So to confirm - this PR is considered a replacement for #5 and #2? Overall everything looks good IMO but to absolutely clarify it would be great to get example files that use this structure from both the mouse V1 and Pinto lab And then schedule a meeting with the Histed group to get their take on the aspects of ours that generalize, and if they'd like to help prepare the NEP document |
Yes, I didn't want to touch #5 since it's working as it is and if we want to go back to the previous implementation, I have a working branch for that.
adding this to the TODO list. |
@alessandratrapani can you address these if you agree:
|
State of this PR: this branch will serve only as an example of how our structure might or could be eventually extended further with minimal effort to account for more dynamic pattern presentations over time However, #7 is the more concise and efficient description of association of patterned stimulation over time per pattern type |
@alessandratrapani Can you fix these merge conflicts when you get a moment? |
This PR is to refine the previous implementation #5:
HolographicSeries
-->PatternedOptogeneticSeries
HolographicStimulusSite
-->PatternedOptogeneticStimulusSite
HolographicStimulusPattern
-->OptogeneticStimulusPattern
SpatialLightModulator
andLightSource
as in suggested in Merge and collaborate with sister extension #6OptogeneticStimulusPattern
:duration
number_of_stimulus_presentation
inter_stimulus_interval
SpiralScanning
andTemporalFocusing