-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend HolographicSeries from Timeseries #5
Extend HolographicSeries from Timeseries #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests and extension overall look very good! k
After thinking about it some more, if we put the rois in the holographicseries then we should be able to make multiple references to a subset of the rois in the plane segmentation table with only a single plane segmentation object, right? Earlier I was worried that we would need to create many plane segmentation objects, but since rois is a dynamic table region, that shouldn't be the case. If we keep rois in the holographic stimulus site, that we would run into the issue that the data array is much bigger than it needs to be if you only stimulates a subset of rois. Sorry for flip-flopping on this issue, I just wanted to consider it and make sure we get it right.
Fix #4