Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #285 .
What problem does this address?
FERC archivers were failing with
Which we thought was related to some other error messages earlier about
But actually those errors were due to concurrency issues with arelle, and we already handled them with retries. The true issue was that
aiohttp.ClientSession.get()
wants astr
oryarl.URL
which is different from thepydantic.networks.HttpUrl
that we were passing in. Oops!What did you change in this PR?
Coerce that bad boy to a string.
Testing
How did you make sure this worked? How can a reviewer verify this?
On main, it fails. On this branch, it succeeds. Et voilà.