Add retries to taxonomy reading. #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdangerx
force-pushed
the
retry-taxonomy-reads
branch
from
26d1e7c
to
679cf33
Compare
jdangerx
requested review from
a team and
zschira
and removed request for
a team
When we try to load a taxonomy multiple times concurrently, we run into `FileExistsError`s as the various threads try to cache files at the same location.
jdangerx
force-pushed
the
retry-taxonomy-reads
branch
from
679cf33
to
23a9309
Compare
zaneselvans
approved these changes
Mar 25, 2024
|
I know you didn't ask for my review but it's quick and I'd love for this to get fully in before the 1st of the month so we can get the new FERC archives nailed down. |
|
Thanks for the review! I had just tagged @catalyst-cooperative/inframundo for review & the round-robin picked @zschira - I had no strong preference for review here :) Fortunately, the FERC monthly archives should already be fixed by this PR. But this is part of getting the PUDL nightly builds to be more reliable, so still worth getting it in sooner rather than later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses catalyst-cooperative/pudl#3449
What problem does this address?
When we try to load a taxonomy multiple times concurrently, we run into
FileExistsErrors as the various threads try to cache files at the same location.What did you change in this PR?
I made us retry the taxonomy read if the cache is confused.
I also added a surprisingly hard-to-write test that runs these taxonomy reads in parallel.
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list
Tasks