Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(port): various debug.cpp improvements #3101

Merged
merged 20 commits into from
Sep 3, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Aug 30, 2023

Summary

SUMMARY: Performance "various debug.cpp improvements"

Purpose of change

  1. improve debug backtrace performance.
  2. get debug backtrace with mold.

Describe the solution

ported DDA PRs related to debug.cpp:

credits to: @BrettDong @jbytheway @xuv

also added LINKER option for cmake to support hot-swapping linkers without compiling everything again

Testing

_01

before (libbacktrace=OFF):

libbacktrace.off.mp4

after (libbacktrace=OFF):

libbacktrace.on.mp4
  • 14.5s -> 1000ms (14.5 times faster)
  • no more ??: ??

only tested on linux, will have to check CI later

@scarf005 scarf005 requested a review from olanti-p August 30, 2023 15:58
@github-actions github-actions bot added the src changes related to source code. label Aug 30, 2023
@scarf005 scarf005 force-pushed the port-libbacktrace branch 3 times, most recently from 66d9ca6 to 4523a16 Compare August 31, 2023 03:18
scarf005 and others added 20 commits September 1, 2023 11:28
was very confusing with `CMAKE_BUILD_TYPE`
Backtrace on Android

from: CleverRaven/Cataclysm-DDA#48371

Co-authored-by: Brett Dong <[email protected]>
demangle RTTI type names in debug messages

from: CleverRaven/Cataclysm-DDA#52633

Co-authored-by: Brett Dong <[email protected]>
Copy link
Collaborator

@Firestorm01X2 Firestorm01X2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@Firestorm01X2 Firestorm01X2 merged commit 1eeea09 into cataclysmbnteam:upload Sep 3, 2023
@scarf005 scarf005 deleted the port-libbacktrace branch September 3, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants