Fix reported version of newer Windows 10 releases #55506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
json-styled
Maleclypse
added
<Bugfix>
github-actions
bot
added
astyled
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Aug 30, 2023
from: CleverRaven/Cataclysm-DDA#55506 Co-authored-by: xuv <[email protected]>
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Aug 31, 2023
from: CleverRaven/Cataclysm-DDA#55506 Co-authored-by: xuv <[email protected]>
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Sep 1, 2023
from: CleverRaven/Cataclysm-DDA#55506 Co-authored-by: xuv <[email protected]>
Firestorm01X2
pushed a commit
to cataclysmbnteam/Cataclysm-BN
that referenced
this pull request
Sep 3, 2023
* chore: unindent common messages was very confusing with `CMAKE_BUILD_TYPE` * fix(port): BSD macro in src/debug.cpp from: CleverRaven/Cataclysm-DDA#47440 Co-authored-by: Brett Dong <[email protected]> * fix(port): Implement C++ symbol demangling on macOS from: CleverRaven/Cataclysm-DDA#47486 Co-authored-by: Brett Dong <[email protected]> * refactor(port): Extract symbol demangling to a separate function from: CleverRaven/Cataclysm-DDA#47517 Co-authored-by: Brett Dong <[email protected]> * feat(port): Demangle symbol names on MinGW from: CleverRaven/Cataclysm-DDA#47517 Co-authored-by: Brett Dong <[email protected]> * feat(port): Implement C++ symbol demangling on Linux from: CleverRaven/Cataclysm-DDA#47621 Co-authored-by: Brett Dong <[email protected]> * feat(port): Implement C++ symbol demangling on FreeBSD and OpenBSD from: CleverRaven/Cataclysm-DDA#48152 Co-authored-by: Brett Dong <[email protected]> * fix(port): C++ symbol demangling on cross-compile MinGW from: CleverRaven/Cataclysm-DDA#48220 Co-authored-by: Brett Dong <[email protected]> * fix(port): memory leak in demangle() from: CleverRaven/Cataclysm-DDA#48230 Co-authored-by: Brett Dong <[email protected]> * feat(port): Backtrace on Android from: CleverRaven/Cataclysm-DDA#48371 Co-authored-by: Brett Dong <[email protected]> * chore(port): hide write_demangled_frame() for Android build from: CleverRaven/Cataclysm-DDA#48414 Co-authored-by: Brett Dong <[email protected]> * feat(port): demangle RTTI type names in debug messages from: CleverRaven/Cataclysm-DDA#52633 Co-authored-by: Brett Dong <[email protected]> * perf(port): optimize null stream in DebugLog from: CleverRaven/Cataclysm-DDA#55156 Co-authored-by: Brett Dong <[email protected]> * fix(port): reported version of newer Windows 10 releases from: CleverRaven/Cataclysm-DDA#55506 Co-authored-by: xuv <[email protected]> * feat(port): include build number in windows version report CleverRaven/Cataclysm-DDA#55646 Co-authored-by: xuv <[email protected]> * feat(port): get the actual static image base of modules from: CleverRaven/Cataclysm-DDA#55782 Co-authored-by: Qrox <[email protected]> * ci: fix version typo * feat(port): support libbacktrace on linux from: CleverRaven/Cataclysm-DDA#59020 Co-authored-by: John Bytheway <[email protected]> * build(cmake): support custom linker context: https://stackoverflow.com//questions/1867745/cmake-use-a-custom-linker#answer-66730019 * docs(cmake): linker, backtrace and libbacktrace --------- Co-authored-by: Brett Dong <[email protected]> Co-authored-by: xuv <[email protected]> Co-authored-by: Qrox <[email protected]> Co-authored-by: John Bytheway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix reported version of newer Windows 10 releases"
Purpose of change
Partial fix for #55454 (this does not address Windows 11 issues)
The Windows registry value containing the release version has changed. I can find no official announcement or documentation, but as best as I can tell 20H2 (aka 2009) introduced the value
DisplayNameand was the last version the oldReleaseIdvalue was updated.In subsequent Windows versions the older value has been left as "2009" and not removed, so many bug reports here with that version number are likely inaccurate. There are a few dozen that report 20H2 and 21H1; at a glance these seem to all come from the
RtlGetVersionfallback since they also include the Windows build number.Describe the solution
This PR makes it so we check for
DisplayNamefirst, falling back toReleaseIdfor older versions.Describe alternatives you've considered
RtlGetVersion: Existing code suggests multiple compilers don't support that function.RtlGetVersionfirst: I'm not qualified to make that decision.Testing
I generated a game report on my own computer running Windows 10 21H2, and the reported version is now correct.
Additional context
Without official documentation I don't know if this new value is intended to be used or will reliably continue, but there are many other projects using a similar solution. Here are a few examples:
NVDA
Lansweeper
detect-windows-version
I also came across this thread, which suggests that all of the values we're currently using are left with "legacy" (aka "wrong") values in Windows 11, so version reporting there will also be inaccurate. I don't have any devices that can run it so I can't investigate that myself.