Port complete leash and lead system #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Port complete leash and lead system"
Purpose of change
I love my cows. After the quadruped armors to protect them I needed a reliable system to move them.
Fixes #781
No but seriously I like this system and thought it would be a great addition in CBN.
Describe the solution
Port the leash and lead system from DDA.
Now animals with the PET_WONT_FOLLOW flag won't follow you by default, but you can attach a leash to them and lead them to move them.
Go here for the complete set of features, it's well explained.
Only difference, I increased the range at which you loose hold of the leash, which means you can safely have up to 6 animals on a leash, whereas with the DDA limitation I couldn't keep more than 2 at a time.
Also, as a side note, this avoids this problem , now animals on a leash can go through Z level just fine.
Otherwise, same features.
Testing
For the reviewer, I had to include the effect.h in monster.h to be able to set permanent effects (cf ".set_permanent()"), because they are working in CBN but a bit tricky to use. In DDA they added functions to set an effect as permanent when adding the effect. If there's a better system let me know.
Additional context
f yeah!