Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-NPC followers (ie horses, summons from the Arcana mod) getting stuck in basements #1422

Open
Proxiehunter opened this issue Mar 29, 2022 · 11 comments
Labels
needs verification Does this bug (still) happen? Needs independent reproduction.

Comments

@Proxiehunter
Copy link

I've seen this happen in let's plays with horses following the player into a basement and refusing to go back up the stairs and today I had a similar issue with a Hunting Horror and a Migo I summoned through the Arcana mod. While I proposed a fix for summons on the Arcana mod github that doesn't really work for horses (and I assume the issue extends to cows, chickens, etc. although chickens dogs and cats can be put in a pet carrier and taken back up). Is there a way to fix it so livestock can't get stuck in basements?

@Proxiehunter
Copy link
Author

Attached the save with my summons stuck in the basement of my evac shelter.

Mods in use:
[
"dda",
"no_npc_food",
"novitamins",
"elevated_bridges",
"Arcana",
"mutant_insects",
"mutant_npcs__",
"deoxymod__",
"SzQmod",
"Tankmod_Revived",
"StatsThroughSkills",
"stats_through_kills",
"Nonperishable_Overhaul"
]

Range.zip

@SaintCirno9
Copy link
Contributor

Not sure if DDA has fixed it, I had this problem too.

@Coolthulhu
Copy link
Member

It's not a trivial problem to solve because of "teleport stairs". Down stairs aren't actually aligned with up stairs in vast majority of cases. Ideally, stairs would have same x/y coords and only differ on z (by +/-1).
Monster AI works in coordinates and thus has problems with this.

I guess it could be solvable by letting more of the critters use NPC-style pathfinding. NPC pathfinding understands teleport stairs.

@SaintCirno9
Copy link
Contributor

You can manually fix the problem by editing the map.
Move the up/down stairs to the same xy location.

@Coolthulhu
Copy link
Member

You can manually fix the problem by editing the map.

Yes, but there will still be locations with this problem. I thought about introducing a debug option that turns off stair teleporting (for testing) and maybe a brute force mapgen test that searches for all mapgen pairs (specials with up/down stairs, mostly) where stairs are misaligned.
I'd expect it to find a ton of mismatches.

@Proxiehunter
Copy link
Author

I guess it could be solvable by letting more of the critters use NPC-style pathfinding. NPC pathfinding understands teleport stairs.

Would giving anything considered "friendly" to the player NPC-style pathfinding be easier or harder than expanding it to multiple critters in a more general way? That's really where the problems are happening, with critters that are friendly to the player and thus follow them down stairs they can't get back up.

@Proxiehunter
Copy link
Author

Would NPC style pathfinding also help them with raised bridges? I discovered today my summoned Migo won't cross a raised bridge at all, my summoned hunting horror tried and got stuck on the bridge, and I had to ride my Dark Wyrm over the bridge but it wouldn't follow on it's own. I assume horses, cows, and other livestock would do the same.

If you want to bring more than one horse/cow over a bridge and don't have a vehicle you put them in and drive over the bridge yet riding them over one at a time would be a pain in the ass. Especially since I often find my characters too heavy to ride horses unless I dump pretty much all of my equipment. Which has lead to me selecting minimum height for all of my characters as that seems to make them light enough to carry more equipment and still ride a horse if I find it. Might raise the fact that you pretty much be the size of a typical jockey to ride a horse as a separate issue later.

@chaosvolt
Copy link
Member

Side note, as I mused in the relevant issue, porting over CleverRaven/Cataclysm-DDA#50890 should make this less of a problem since that'd give players a manual solution, only issue is I dunno if that PR tested trying to lead up/down stairs or not.

Oh wait, okay.

Works across z-levels as long as the up/down stairs are aligned (otherwise the player will be too far from the animal after using the stairs)

Well shit.

@LyleSY
Copy link
Contributor

LyleSY commented Sep 21, 2022

This is a big issue for DinoMod also. I have a horrible hack I'm planning to port over but an actual fix would be even better

@chaosvolt
Copy link
Member

Anything helps hopefully. On Arcana's end, I have set aside chaosvolt/cdda-arcana-mod#275 as a thing that will help make summoned monsters less annoying to wrangle, but there's some UI stuff I want to make fuck with beforehand...

@chaosvolt
Copy link
Member

chaosvolt commented Oct 2, 2022

The above Arcana PR is now set so that once #1931 is merged I should be good to merge that, so that'll take care of things on Arcana's end at least.

#1905 should also improve this once merged, via adding an additional way to get an ornery monster follower up and down stairs (I hope, I might want to check out their branch to see for myself).

@Drugitechnik Drugitechnik added the needs verification Does this bug (still) happen? Needs independent reproduction. label Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs verification Does this bug (still) happen? Needs independent reproduction.
Projects
None yet
Development

No branches or pull requests

6 participants