Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed rock_pot References #1492

Merged

Conversation

KheirFerrum
Copy link
Collaborator

@KheirFerrum KheirFerrum commented Apr 27, 2022

Summary

SUMMARY: Bugfixes "Removed references to obsoleted item Stone Pot."

Purpose of change

While the stone pot is obsoleted, there are still places where it is referenced, misleading players into believing such a recipe exists. [Credit to silverwing235 on the discord for bringing this to my attention]

Describe the solution

Removed all remaining references to the stone pot in construction recipes.

Describe alternatives you've considered

... Add it back?

Testing

Additional context

Kind of telling that this hasn't been fixed in so long, we really need to look at the faction camp system at some point.

Why was this not removed back when rock_pots were obsoleted?
@Proxiehunter
Copy link

Why was the stone pot removed in the first place? It seems such things really existed.

As for the faction camps system, when I finally get around to my youtube videos on how to get started playing Bright Nights I have a whole damn thing on how about 99% of the faction camps system is useless. Early stages get you the ability to send NPC's out to hunt or trap and there's the radio tower to recruit new NPC's but most of the rest can be done faster if you just make the things yourself with a few edge cases where NPC's can make items you don't have the recipes for. Even the faction camp farm is useless. You can give them a shovel and order them to make fields, plant fields, and harvest fields without one. The faction camp version just takes time and resources that are better spent. Did a whole play through diving as deep into that as I can. Needs reworked from the godsdamned ground up.

@KheirFerrum
Copy link
Collaborator Author

Why was the stone pot removed in the first place? It seems such things really existed.

#36416. Having looked it over, while a stone pot has existed in time, it's not likely to be craftable from the original recipe. We could in fact add it back, but the requirements would likely be different.

Personally I have no real beef with the idea, and the whole "the recipe is nonsense" should have meant changing the tool requirements if you ask me.

As for the faction camps system, when I finally get around to my youtube videos on how to get started playing Bright Nights I have a whole damn thing on how about 99% of the faction camps system is useless. Early stages get you the ability to send NPC's out to hunt or trap and there's the radio tower to recruit new NPC's but most of the rest can be done faster if you just make the things yourself with a few edge cases where NPC's can make items you don't have the recipes for. Even the faction camp farm is useless. You can give them a shovel and order them to make fields, plant fields, and harvest fields without one. The faction camp version just takes time and resources that are better spent. Did a whole play through diving as deep into that as I can. Needs reworked from the godsdamned ground up.

I can't really deny that, having tried the faction camp system I'm not particularly satisfied with it. We're stretched pretty thin though, between the various things we want to fix, add and change, so faction camps are pretty low priority. Sorry about that.

@Proxiehunter
Copy link

I can't really deny that, having tried the faction camp system I'm not particularly satisfied with it. We're stretched pretty thin though, between the various things we want to fix, add and change, so faction camps are pretty low priority. Sorry about that.

Wasn't as much of a complaint as it was a warning to anyone who reads it, don't dive deep into the faction camp system. If someone who understands how it works gets motivated at some point to make changes so it's better that would be great but it's understandable that there are more important matters to be dealt with.

@Coolthulhu Coolthulhu self-assigned this Apr 30, 2022
@Coolthulhu Coolthulhu merged commit b332b60 into cataclysmbnteam:upload May 3, 2022
@KheirFerrum KheirFerrum deleted the Remove-Stone-Pot-References branch May 3, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants