-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow moving zone position #1364
Conversation
Nice! Does it work with zones on vehicles? I see the following cases:
|
/home/runner/work/Cataclysm-BN/Cataclysm-BN/src/game.cpp: In member function ‘void game::zones_manager()’:
Error: /home/runner/work/Cataclysm-BN/Cataclysm-BN/src/game.cpp:6686:108: error: cannot bind non-const lvalue reference of type ‘tripoint&’ to an rvalue of type ‘tripoint’
const look_around_result result_local = look_around( false, zone_local_start_point + tripoint_zero,
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~ For some reason, the |
Because currently vzones only support 1x1 size, so I don't think there is any necessity to enable moving for vehicle zones, I may do that after vzones can be larger. |
|
Summary
SUMMARY: [Features] "Allow moving zone position"
Purpose of change
Currently, the only way to change the position of a zone is to re-edit the zone, but in many cases it is more convenient to move the area directly than to re-edit. So it's a good idea to add a feature to move the zone directly.
Describe the solution
Add a new option below the option "Edit position", now the window looks like this:
You can then use the keyboard to move the zone:
or mouse:
If z-levels are enabled, moving zone across z-levels can also function, as shown in the gif above.
Describe alternatives you've considered
Testing
Create a new zone, select it and move it around, the zone saves fine.
Load an old save with existing zones, those zones can also be moved.
Additional context