Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movable zones #56422

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Movable zones #56422

merged 3 commits into from
Apr 20, 2022

Conversation

ZombieZilla
Copy link
Contributor

@ZombieZilla ZombieZilla commented Mar 28, 2022

Summary

Interface "Zones can now be shifted around"

Purpose of change

Allows you to directly shift the location of a zone, rather than having to redesignate it every time.

Describe the solution

Add an additional menu option, "Move position", allowing for keyboard or mouse input to shift the zone around.

Describe alternatives you've considered

Testing

Spawned a variety of static and personal zones. Shifting, shifting across Z-levels, regular editing, sorting after shifting and all other general actions I could think of all worked without a problem.

Additional context

I'm still quite new to C++, so if there is any poor coding practises, please point it out.

Changes from (with some modification):
cataclysmbnteam/Cataclysm-BN#1364
cataclysmbnteam/Cataclysm-BN#1385
Original author added as commit co-author

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 28, 2022
@ZombieZilla ZombieZilla marked this pull request as draft March 29, 2022 10:08
@ZombieZilla

This comment was marked as outdated.

@ZombieZilla ZombieZilla marked this pull request as ready for review March 30, 2022 12:49
@github-actions github-actions bot added the Info / User Interface Game - player communication, menus, etc. label Apr 18, 2022
@kevingranade kevingranade merged commit 7e4a868 into CleverRaven:master Apr 20, 2022
@ZombieZilla ZombieZilla deleted the movable-zones branch April 25, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants