Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of regression script #1179

Merged
merged 6 commits into from
May 11, 2020
Merged

Cleanup of regression script #1179

merged 6 commits into from
May 11, 2020

Conversation

lintool
Copy link
Member

@lintool lintool commented May 10, 2020

The regression documentation has drifted slightly away from the actual working regression commands - for example, the index paths. General cleanup to bring back into alignment.

@lintool lintool requested a review from lukuang May 10, 2020 13:35
@codecov
Copy link

codecov bot commented May 10, 2020 •
edited
Loading

Codecov Report

Merging #1179 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1179      +/-   ##
============================================
- Coverage     48.16%   48.15%   -0.02%     
+ Complexity      720      719       -1     
============================================
  Files           146      146              
  Lines          8396     8396              
  Branches       1197     1197              
============================================
- Hits           4044     4043       -1     
  Misses         4012     4012              
- Partials        340      341       +1
Impacted Files Coverage Δ Complexity Δ
...anserini/ltr/feature/base/PMIFeatureExtractor.java 84.61% <0.00%> (-1.93%) 12.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693eb5d...bf76206. Read the comment docs.

lukuang
lukuang reviewed May 11, 2020
View reviewed changes
Copy link
Collaborator

@lukuang lukuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking

src/main/python/run_regression.py Outdated Show resolved Hide resolved
lukuang
lukuang approved these changes May 11, 2020
View reviewed changes
Copy link
Collaborator

@lukuang lukuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lintool lintool merged commit cee4463 into master May 11, 2020
@lintool lintool deleted the regression-cleanup branch May 11, 2020 16:05
crystina-z pushed a commit to crystina-z/anserini that referenced this pull request Oct 28, 2022
@lintool
Update repro matrix: refactor code and update test cases (castorini#1179
20d4be4 
)

There used to be four separate scripts, one for each MS MARCO collection:
scripts combined into a single one, reducing code duplication.

Still need a few more pre-built indexes, but most rows from our forthcoming
SIGIR 2022 paper are covered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukuang lukuang lukuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lintool @lukuang