-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant when_null_skip=
kwarg
#732
Comments
pivotaljohn
pushed a commit
to carvel-dev/carvel
that referenced
this issue
Sep 6, 2022
Removed as part of carvel-dev/ytt#732
pivotaljohn
pushed a commit
to carvel-dev/carvel
that referenced
this issue
Sep 6, 2022
Removed as part of carvel-dev/ytt#732
pivotaljohn
pushed a commit
to carvel-dev/carvel
that referenced
this issue
Sep 7, 2022
Identified as redundant as described in carvel-dev/ytt#732.
pivotaljohn
pushed a commit
that referenced
this issue
Sep 7, 2022
Repository owner
moved this from Needs Review
to Closed
in Carvel
Sep 7, 2022
mamachanko
pushed a commit
to mamachanko/carvel
that referenced
this issue
Oct 24, 2022
Identified as redundant as described in carvel-dev/ytt#732.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the design of
ytt
Validations, we proposed that nullable Data Values would require the configuration to skip validation should the value remainnull
.This has been implemented as the
when_null_skip=
keyword argument.However, through adjustments in design made during implementation and usability testing (#707), we've determined that this mechanism is not needed in practice:
@schema/nullable
thewhen_null_skip=
is defaulted toTrue
;null
, the only interesting validation rule is to assert that it not be null (e.g.not_null=True
);when_null_skip=
would be set explicitly toFalse
, it would practically need to be accompanied with anot_null=True
;not_null=True
the value forwhen_null_skip=
is ignored;This work includes (by may not be limited to):
The text was updated successfully, but these errors were encountered: