Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant when_null_skip= kwarg #732

Closed
3 tasks done
Tracked by #561
pivotaljohn opened this issue Sep 3, 2022 · 0 comments · Fixed by #737
Closed
3 tasks done
Tracked by #561

Remove redundant when_null_skip= kwarg #732

pivotaljohn opened this issue Sep 3, 2022 · 0 comments · Fixed by #737
Assignees

Comments

@pivotaljohn
Copy link
Contributor

pivotaljohn commented Sep 3, 2022

In the design of ytt Validations, we proposed that nullable Data Values would require the configuration to skip validation should the value remain null.
This has been implemented as the when_null_skip= keyword argument.

However, through adjustments in design made during implementation and usability testing (#707), we've determined that this mechanism is not needed in practice:

  • when a Data Value has been marked as @schema/nullable the when_null_skip= is defaulted to True;
  • in practice, when a value is null, the only interesting validation rule is to assert that it not be null (e.g. not_null=True);
  • so, the only time when when_null_skip= would be set explicitly to False, it would practically need to be accompanied with a not_null=True;
  • however, when not_null=True the value for when_null_skip= is ignored;
  • therefore, this flag meets no true need/use-case for users.

This work includes (by may not be limited to):

@pivotaljohn pivotaljohn mentioned this issue Sep 3, 2022
19 tasks
@carvel-bot carvel-bot added this to Carvel Sep 3, 2022
@carvel-bot carvel-bot moved this to To Triage in Carvel Sep 3, 2022
@pivotaljohn pivotaljohn moved this from To Triage to Prioritized Backlog in Carvel Sep 3, 2022
@pivotaljohn pivotaljohn moved this from Prioritized Backlog to In Progress in Carvel Sep 6, 2022
@pivotaljohn pivotaljohn self-assigned this Sep 6, 2022
pivotaljohn pushed a commit to carvel-dev/carvel that referenced this issue Sep 6, 2022
pivotaljohn pushed a commit to carvel-dev/carvel that referenced this issue Sep 6, 2022
pivotaljohn pushed a commit to carvel-dev/carvel that referenced this issue Sep 7, 2022
@pivotaljohn pivotaljohn moved this from In Progress to Needs Review in Carvel Sep 7, 2022
pivotaljohn pushed a commit that referenced this issue Sep 7, 2022
Repository owner moved this from Needs Review to Closed in Carvel Sep 7, 2022
mamachanko pushed a commit to mamachanko/carvel that referenced this issue Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant