Use ggcr library to write images with non-distributable layers #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use ggcr library to write non-distributable layers Authored-by: Dennis Leon <[email protected]>
cppforlife
reviewed
Mar 26, 2021
cppforlife
reviewed
Mar 26, 2021
cppforlife
reviewed
Mar 26, 2021
cppforlife
reviewed
Mar 26, 2021
- Add a new line in registryOpts struct fields to separate 'groups' - Move ImageLayerWriterFilter into tarwriter package since that is the only place it is used now - rename variable to make its intent more obvious - inline the IncludeNonDistributableFlag into the `CopyOptions` Authored-by: Dennis Leon <[email protected]>
DennisDenuto
force-pushed
the
refactor-non-distr-layers-63
branch
from
7389712 to
7df8ba2
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been an upstream change made to ggcr that allows configuring
WriteandMultiWriteto write layers that have a media type of 'non-distributable'.This PR removes the previous approach of handling writing non-dist layers, and instead delegates to the library.
Another nice benefits (apart from less code) is potential performance improvement due to de-duping layer logic now also applied to non-dist layers