Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow writing a non-distributable layer upstream #63

Closed
5 tasks done
gcheadle-vmware opened this issue Jan 28, 2021 · 4 comments
Closed
5 tasks done

Allow writing a non-distributable layer upstream #63

gcheadle-vmware opened this issue Jan 28, 2021 · 4 comments
Assignees

Comments

@gcheadle-vmware
Copy link
Contributor

gcheadle-vmware commented Jan 28, 2021

Context

As part of #62 a 'workaround' solution was found to ggcr's inability to write a non-distributable layer.

The workaround solution was to write the 'foreign' layers upfront before trying to write the image manifest.

We decided to proceed with the workaround solution, since there was some urgency behind getting window images working. See https://kubernetes.slack.com/archives/CH8KCCKA5/p1598013615011900

Description

Create a PR or Issue to https://github.com/google/go-containerregistry to allow writing a non-distributable layer.
Change imgpkg to use the above change to writing an image manifest that contains a 'foreign' image layer.

Notes

  • There's a closed issue that has some background.
  • Matt Moore ([email protected]) worked on this library if it's difficult getting traction in the repo

Tasks

  • Introduce Option to allow specifying "allow non distributable layers"
  • Wherever that option is used, support the allowance
    • Write (this is all we really need, but the options are also used...)
    • MultiWrite
  • Add task to use upstream GGCR functionality OR create a story to do so.
@StevenLocke
Copy link
Contributor

Made the PR in upstream GGCR. Currently blocked on signing the CLA, unsure if that should be done as an individual or for the company.

After that gets merged, we should use it in imgpkg!

@aaronshurley
Copy link
Contributor

Looks like the PR was merged a couple of weeks back but has not been part of a release yet. Let's keep this issue open until we can consume the upstream changes.

@DennisDenuto
Copy link
Contributor

go-container registry released 0.4.1 that contains the PR to non-distributable layers

https://github.com/google/go-containerregistry/releases/tag/v0.4.1

@aaronshurley
Copy link
Contributor

This issue was resolved in #110 and released in v0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants