Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply OpenColorIO Transformations in Render Pass #319

Merged
merged 11 commits into from
Oct 17, 2022
Merged

Apply OpenColorIO Transformations in Render Pass #319

merged 11 commits into from
Oct 17, 2022

Conversation

carson-katri
Copy link
Owner

@carson-katri carson-katri commented Oct 16, 2022 •
edited
Loading

  • Refactors the GeneratorProcess into multiple files (per-intent)
  • Re-implements Blender's color management transformations in Python. This fixes discrepancies between the image passed to DT and the Combined render pass output Render Pass does not apply gamma correction or view transform #277
  • Added a Dream Textures Seed render pass with a single value... Not sure how useful this will be atm
  • Fixes a bug where any enabled render passes that do not have 4 components would break the render (such as the Z/Depth pass) Cycles Render Pass not showing up #295

@carson-katri carson-katri added bug Something isn't working render pass labels Oct 16, 2022
@carson-katri carson-katri added this to the v0.0.8 milestone Oct 16, 2022
This was linked to issues Oct 16, 2022
Cycles Render Pass not showing up #295
Closed
Render Pass does not apply gamma correction or view transform #277
Closed
@carson-katri
Copy link
Owner Author

I had to manually merge the changes from #317 and #318, so let me know if you notice any mistakes there as well.

@carson-katri
Copy link
Owner Author

FYI I added the PyOpenColorIO package to the requirements file, so that will need to be installed for this to work.

NullSenseStudio
NullSenseStudio requested changes Oct 16, 2022
View reviewed changes
carson-katri and others added 2 commits October 16, 2022 14:11
@carson-katri @NullSenseStudio
Fix exposure argument
f074118 
Co-authored-by: NullSenseStudio <[email protected]>
@carson-katri @NullSenseStudio
Delay next(generator_advance)
726ae04 
Co-authored-by: NullSenseStudio <[email protected]>
NullSenseStudio
NullSenseStudio reviewed Oct 16, 2022
View reviewed changes
@carson-katri @NullSenseStudio
Update __init__.py
4406be0 
Co-authored-by: NullSenseStudio <[email protected]>
@carson-katri carson-katri merged commit 9d98080 into main Oct 17, 2022
@carson-katri carson-katri deleted the render-pass-fix branch October 17, 2022 00:18
JasonHoku pushed a commit to JasonHoku/dream-textures that referenced this pull request Dec 20, 2022
@carson-katri @NullSenseStudio @JasonHoku
Apply OpenColorIO Transformations in Render Pass (carson-katri#319)
ba465ef 
* Use OpenColorIO to fix color management in render pass

* Refactor generator into separate files per intent

* Add apply_ocio_transforms intent

* Fix non-RGB render pass copying

* Fix exposure argument

Co-authored-by: NullSenseStudio <[email protected]>

* Delay next(generator_advance)

Co-authored-by: NullSenseStudio <[email protected]>

* Perform inverse transform

* Add opencolorio dependency for other platforms

* Update __init__.py

Co-authored-by: NullSenseStudio <[email protected]>

Co-authored-by: NullSenseStudio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullSenseStudio NullSenseStudio NullSenseStudio requested changes

Assignees
No one assigned
Labels
bug Something isn't working render pass
Projects
None yet
Milestone
v0.0.8
Development

Successfully merging this pull request may close these issues.

Cycles Render Pass not showing up Render Pass does not apply gamma correction or view transform
2 participants
@carson-katri @NullSenseStudio