Import Fixes #317
Merged
Import Fixes #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonHoku
pushed a commit
to JasonHoku/dream-textures
that referenced
this pull request
Dec 20, 2022
* restrict PYTHONPATH and user site from subprocess * reorder sys.path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some people the subprocess has managed to load external modules and cause odd issues. I've tracked down these ways that it may happen and should no longer be a problem with these changes.
--python-use-system-envsince the subprocess inherits Blender's environment variables. Now it'll always be removed from the subprocess's environment.--python-use-system-env, but the subprocess doesn't inherit this functionality.-scommand line argument will prevent this.sys.pathso modules will be looked for within the addon before any paths from the python interpreter.Only reported issue that I know this will fix is #205 (loaded an outdated version of pillow, likely within user site like Smuzzies commented). Potentially others that haven't been properly tracked down too.