-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add class for images with a drop shadow #514
add class for images with a drop shadow #514
Conversation
@tobyhodges, would you mind updating the PR to have a single drop shadow only? Or is there a case where two similar shadows are useful? Also, what do you think about changing |
This fell off my radar, sorry. I have made a note to update the branch after the Core Team retreat is over (next week) |
@maxim-belkin updated to use a single, grey shadow as you proposed. I did not adjust the selector to apply this shadow to all images in the |
Thanks, Toby. Looks good. Current selector works when used like so: ![alt text](../fig/figure.png){: .image-with-shadow}
![alt text](../fig/figure2.png){: class="image-with-shadow"} I have to admit that in my first attempt I did:
which resulted in the following HTML structure: p.image-with-shadow img,
img.image-with-shadow { ... |
That is a great suggestion, @maxim-belkin, because I agree that many lesson authors are likely to try what you tried (it is also what my muscle memory tries to make me do every time!) |
Addressed in 4b20368 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍🏻
Thank you, Toby! |
To address the issue described in #513, this introduces a
img.image-with-shadow
class with a drop shadow. If and when this is accepted, I'll document it in the lesson example.