-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remake all screenshots #107
Comments
For adding borders in a somewhat automated way, using the
|
As suggested by @maxim-belkin in the issue thread on the lesson template repository we can add a border to specific images/screenshots by providing the CSS right after the image is embedded:
I have tested locally and can confirm this works. It's also the way we can specify the width of the image without resorting to HTML |
For a more pleasing look, we could perhaps also consider a drop-shadow effect. If the second suggestion (using a CSS class) also works (didn't test yet) that's certainly more maintainable. |
Indeed. I'm rustling up a PR to add the class to the lesson template. I agree that the drop shadow looks nicer, so I'll go for that. (If you're interested to learn more, read more about these inline attribute lists (IALS) in kramdown.) |
Just noticed some of the screenshots in the GitHub Pages episode show |
carpentries/styles#514 was just merged, so (once we merge the upstream changes) we can apply drop shadow to images by applying the |
Think this might need to wait again until we finish some other changes to the lesson. Still want to fill in the screenshots where there are |
Recording some ideas discussed today.
@tobyhodges Regarding 1. would this be acceptable use of the incubator org? Regarding 3. has this or any form of it ever been raised centrally with The Carpentries? |
#247 includes While working on #186 I found the "Responsive view" mode in Firefox to be quite convenient to have fixed dimensions and resolution for screenshots. It even includes a handy "Take a screenshot of the viewport" button on the top-right corner of the screen. You can enable this mode with Ctrl+Shift+M or Cmd+Opt+M on MacOS. The mode is also available in Chrome, but you need to have the developer tools open for it to work. You need F12 and then you can hit Ctrl+Shift+M. I found that 1200x1000 for viewport screenshots works well. Narrower sizes and you end up with tablet or phone-like views. Wider and you end up with a decent amount of unused screen space. |
Only one FIXME screenshot left now in the "Arrays"/"Loops and Collections" episode. |
Addressed in #255 |
We have several issues with the current screenshots:
After the two pilot workshops and when the lessons have become more stable we need to remake all the screenshots and standardize them.
The text was updated successfully, but these errors were encountered: