Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remake all screenshots #107

Closed
sstevens2 opened this issue Nov 4, 2020 · 12 comments
Closed

Remake all screenshots #107

sstevens2 opened this issue Nov 4, 2020 · 12 comments
Assignees
Labels
type:clarification Suggest change for make lesson clearer

Comments

@sstevens2
Copy link
Contributor

We have several issues with the current screenshots:

  • various sizes/resolutions
  • different usernames
  • extensions showing (gitpod)
  • whitespace in screenshots makes it hard to differentiate the screenshots and the surrounding lesson text

After the two pilot workshops and when the lessons have become more stable we need to remake all the screenshots and standardize them.

@sstevens2 sstevens2 added the status:wait Progress dependent on another issue or conversation label Nov 4, 2020
@sstevens2 sstevens2 self-assigned this Nov 4, 2020
@sstevens2
Copy link
Contributor Author

See #95 and #51 for more info

@unode
Copy link
Contributor

unode commented Nov 4, 2020

For adding borders in a somewhat automated way, using the convert command from ImageMagick:

convert original.png -bordercolor '#d7d7db' -compose Copy -border 5 original_with_border.png

@tobyhodges
Copy link
Member

As suggested by @maxim-belkin in the issue thread on the lesson template repository we can add a border to specific images/screenshots by providing the CSS right after the image is embedded:

![Blank new repository page](../fig/blank_new_repo.png){: style="border: solid 1px #d7d7db; background: #eee;" width="600px" }

I have tested locally and can confirm this works. It's also the way we can specify the width of the image without resorting to HTML img tags. It will be good to add the border to screenshots in the lesson while this issue is being addressed.

@unode
Copy link
Contributor

unode commented Nov 5, 2020

For a more pleasing look, we could perhaps also consider a drop-shadow effect.
https://www.w3schools.com/css/tryit.asp?filename=trycss3_box-shadow5

If the second suggestion (using a CSS class) also works (didn't test yet) that's certainly more maintainable.

@tobyhodges
Copy link
Member

tobyhodges commented Nov 5, 2020

If the second suggestion (using a CSS class) also works (didn't test yet) that's certainly more maintainable.

Indeed. I'm rustling up a PR to add the class to the lesson template. I agree that the drop shadow looks nicer, so I'll go for that.

(If you're interested to learn more, read more about these inline attribute lists (IALS) in kramdown.)

@tobyhodges
Copy link
Member

Just noticed some of the screenshots in the GitHub Pages episode show gh-pages as the target branch for Pages builds. So these definitely need updating when this issue is addressed...

@tobyhodges tobyhodges added help wanted Looking for Contributors and removed status:wait Progress dependent on another issue or conversation labels Nov 26, 2020
@tobyhodges
Copy link
Member

carpentries/styles#514 was just merged, so (once we merge the upstream changes) we can apply drop shadow to images by applying the .image-with-shadow class.

@sstevens2 sstevens2 added status:wait Progress dependent on another issue or conversation and removed help wanted Looking for Contributors labels Apr 6, 2021
@sstevens2
Copy link
Contributor Author

Think this might need to wait again until we finish some other changes to the lesson. Still want to fill in the screenshots where there are FIXME's but want to wait to redo the rest.

@unode
Copy link
Contributor

unode commented Apr 7, 2021

Recording some ideas discussed today.
To avoid having screenshots with different authors and repository owners.

  1. We can create a jekyll-pages-novice-example repository in carpentries-incubator or another organization we are all part of.
  2. We can modify git.user.email to [email protected] or another The Carpentries email and git.user.name to "The Carpentries". Would work for changes done locally but not for changes done via GitHub (see 3.).
  3. Alternatively we could create an account that we share (for changes via GitHub) but @sstevens2 mentioned we could be breaching GitHub's ToS while doing this.

@tobyhodges Regarding 1. would this be acceptable use of the incubator org? Regarding 3. has this or any form of it ever been raised centrally with The Carpentries?

@unode
Copy link
Contributor

unode commented May 16, 2021

#247 includes .image-with-shadow @tobyhodges mentioned above. 🎉

While working on #186 I found the "Responsive view" mode in Firefox to be quite convenient to have fixed dimensions and resolution for screenshots. It even includes a handy "Take a screenshot of the viewport" button on the top-right corner of the screen. You can enable this mode with Ctrl+Shift+M or Cmd+Opt+M on MacOS.

The mode is also available in Chrome, but you need to have the developer tools open for it to work. You need F12 and then you can hit Ctrl+Shift+M.

I found that 1200x1000 for viewport screenshots works well. Narrower sizes and you end up with tablet or phone-like views. Wider and you end up with a decent amount of unused screen space.

@tobyhodges tobyhodges added the type:clarification Suggest change for make lesson clearer label May 17, 2021
@anenadic
Copy link
Contributor

Only one FIXME screenshot left now in the "Arrays"/"Loops and Collections" episode.

@tobyhodges tobyhodges removed the status:wait Progress dependent on another issue or conversation label Jun 21, 2021
@tobyhodges
Copy link
Member

Addressed in #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:clarification Suggest change for make lesson clearer
Projects
None yet
Development

No branches or pull requests

4 participants